Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 2719603002: Rename Closure instance field type_arguments_ to instantiator_. (Closed)
Patch Set: work in progress Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/deferred_objects.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index cd7733be013d1ecef60e3a711f88435d7a71d74e..b5061df62c0c177a370d615ce6f4d2f04399b615 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -2394,7 +2394,7 @@ void EffectGraphVisitor::VisitClosureNode(ClosureNode* node) {
Value* closure_val = Bind(alloc);
{
LocalVariable* closure_tmp_var = EnterTempLocalScope(closure_val);
- // Store type arguments if scope class is generic.
+ // Store instantiator type arguments if scope class is generic.
const Type& function_type = Type::ZoneHandle(Z, function.SignatureType());
const Class& scope_cls = Class::ZoneHandle(Z, function_type.type_class());
if (scope_cls.IsGeneric()) {
@@ -2405,7 +2405,7 @@ void EffectGraphVisitor::VisitClosureNode(ClosureNode* node) {
Class::Handle(Z, owner()->function().Owner());
Value* type_arguments = BuildInstantiatorTypeArguments(
node->token_pos(), instantiator_class, NULL);
- Do(new (Z) StoreInstanceFieldInstr(Closure::type_arguments_offset(),
+ Do(new (Z) StoreInstanceFieldInstr(Closure::instantiator_offset(),
closure_tmp_val, type_arguments,
kEmitStoreBarrier, node->token_pos()));
}
« no previous file with comments | « runtime/vm/deferred_objects.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698