Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: runtime/vm/deferred_objects.cc

Issue 2719603002: Rename Closure instance field type_arguments_ to instantiator_. (Closed)
Patch Set: work in progress Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/deferred_objects.cc
diff --git a/runtime/vm/deferred_objects.cc b/runtime/vm/deferred_objects.cc
index f21716ac167d9a79032d2b525a5737813eb3be29..4e2b3da06421b41689a0466410ac8537e1337104 100644
--- a/runtime/vm/deferred_objects.cc
+++ b/runtime/vm/deferred_objects.cc
@@ -297,45 +297,6 @@ void DeferredObject::Fill() {
}
}
}
- } else if (cls.id() == kClosureCid) {
- // TODO(regis): It would be better to programmatically add these fields to
- // the VM Closure class. Declaring them in the Dart class _Closure does not
- // work, because the class is prefinalized and CalculateFieldOffsets is
- // therefore not called. Resetting the finalization state may be an option.
- const Closure& closure = Closure::Cast(*object_);
-
- Smi& offset = Smi::Handle();
- Object& value = Object::Handle();
-
- for (intptr_t i = 0; i < field_count_; i++) {
- offset ^= GetFieldOffset(i);
- if (offset.Value() == Closure::type_arguments_offset()) {
- TypeArguments& arguments = TypeArguments::Handle();
- arguments ^= GetValue(i);
- closure.SetTypeArguments(arguments);
- if (FLAG_trace_deoptimization_verbose) {
- OS::PrintErr(" closure@type_arguments (offset %" Pd ") <- %s\n",
- offset.Value(), value.ToCString());
- }
- } else if (offset.Value() == Closure::function_offset()) {
- Function& function = Function::Handle();
- function ^= GetValue(i);
- closure.set_function(function);
- if (FLAG_trace_deoptimization_verbose) {
- OS::PrintErr(" closure@function (offset %" Pd ") <- %s\n",
- offset.Value(), value.ToCString());
- }
- } else {
- ASSERT(offset.Value() == Closure::context_offset());
- Context& context = Context::Handle();
- context ^= GetValue(i);
- closure.set_context(context);
- if (FLAG_trace_deoptimization_verbose) {
- OS::PrintErr(" closure@context (offset %" Pd ") <- %s\n",
- offset.Value(), value.ToCString());
- }
- }
- }
} else {
const Instance& obj = Instance::Cast(*object_);
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698