Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2719573002: Fix SSL certificate being wrong in the intended_as_new_entry case of NAVIGATION_TYPE_EXISTING_PAGE. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix SSL certificate being wrong in the intended_as_new_entry case of NAVIGATION_TYPE_EXISTING_PAGE. It turns out that in some rare race conditions, this section of the code could get reached with a different origin for the committed page and the NavigationEntry that was reused. In that case, make sure to use the SSL certificate from the NavigationHandle instead of resusing the old one. BUG=688425 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2707133003 Cr-Commit-Position: refs/heads/master@{#452106} (cherry picked from commit a78746ec1a1bfa668f5bcb01d2b2665d2c514369) Review-Url: https://codereview.chromium.org/2719573002 . Cr-Commit-Position: refs/branch-heads/2987@{#680} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/d37f8f3c85e4c2f6c5d040478f5067969f278650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jam
3 years, 10 months ago (2017-02-24 19:21:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d37f8f3c85e4c2f6c5d040478f5067969f278650.

Powered by Google App Engine
This is Rietveld 408576698