Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2719513003: Adding success/failure notification haptics for HUD display. (Closed)

Created:
3 years, 10 months ago by pink (ping after 24hrs)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding success/failure notification haptics for HUD display. When we show a HUD bar for certain features, accompany it with a haptic indicating success or failure. This adds haptics for: - OS sharing success - print failures - password filling from 3rd party (ie, 1Password). - adding to reading list. BUG=695914 TEST=Manual test only. See https://bugs.chromium.org/p/chromium/issues/detail?id=695914#c4 for manual test steps. Review-Url: https://codereview.chromium.org/2719513003 Cr-Commit-Position: refs/heads/master@{#454265} Committed: https://chromium.googlesource.com/chromium/src/+/07e27841f0a5a7c76d0192dd0a509a0c22aa5763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 4 chunks +7 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util.mm View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
pink (ping after 24hrs)
3 years, 9 months ago (2017-02-27 15:55:43 UTC) #6
rohitrao (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-02 14:58:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719513003/1
3 years, 9 months ago (2017-03-02 15:12:42 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 15:29:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/07e27841f0a5a7c76d0192dd0a50...

Powered by Google App Engine
This is Rietveld 408576698