Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2719493002: Remove 'begin'/'end' processing from SVGSMILElement::svgAttributeChanged (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 'begin'/'end' processing from SVGSMILElement::svgAttributeChanged The svgAttributeChanged hook is (with one exception) used for attributes that are part of the SVG DOM representation ("object model".) 'begin' and 'end' are not. Move handling to SVGSMILElement::parseAttribute instead. BUG=641437 Review-Url: https://codereview.chromium.org/2719493002 Cr-Commit-Position: refs/heads/master@{#452858} Committed: https://chromium.googlesource.com/chromium/src/+/c4d290969dc798f99086633d30f20e794e314b4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 10 months ago (2017-02-24 14:22:26 UTC) #5
Stephen Chennney
On 2017/02/24 14:22:26, fs wrote: lgtm
3 years, 10 months ago (2017-02-24 16:18:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719493002/1
3 years, 10 months ago (2017-02-24 17:24:58 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 17:31:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4d290969dc798f99086633d30f2...

Powered by Google App Engine
This is Rietveld 408576698