Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2719483003: Clean up webkitpy.layout_tests.port.factory. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up webkitpy.layout_tests.port.factory. In this CL: Make docstring style consistent Make quotes consistent Move helper functions to below main class Edit comments This CL should not change behavior. Reason for this change: Was reading this file when making another change and saw a few trivial things to improve. Review-Url: https://codereview.chromium.org/2719483003 Cr-Commit-Position: refs/heads/master@{#453283} Committed: https://chromium.googlesource.com/chromium/src/+/f3303da50d08471efcb8ddf8db61c4d60aebee7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -79 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py View 5 chunks +81 lines, -79 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
qyearsley
3 years, 10 months ago (2017-02-24 22:33:30 UTC) #2
jeffcarp
lgtm
3 years, 9 months ago (2017-02-27 18:55:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719483003/1
3 years, 9 months ago (2017-02-27 19:01:43 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 19:11:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f3303da50d08471efcb8ddf8db61...

Powered by Google App Engine
This is Rietveld 408576698