Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2719403005: Revert of Add integration tests for WebAPKs (Closed)

Created:
3 years, 9 months ago by Sergey Ulanov
Modified:
3 years, 9 months ago
Reviewers:
pkotwicz, gone, agrieve
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add integration tests for WebAPKs (patchset #5 id:180001 of https://codereview.chromium.org/2701333002/ ) Reason for revert: Broke android build: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Builder Original issue's description: > Add integration tests for WebAPKs > > This CL adds an integration test to verify that launching a WebAPK: > - Does not crash > - The initial URL eventually finishes loading > - The splash screen eventually hides > > BUG=691848 > > Review-Url: https://codereview.chromium.org/2701333002 > Cr-Commit-Position: refs/heads/master@{#453700} > Committed: https://chromium.googlesource.com/chromium/src/+/6a6e60653e99e4f6ae358a282e2893d05ef04427 TBR=dfalcantara@chromium.org,agrieve@chromium.org,pkotwicz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691848 Review-Url: https://codereview.chromium.org/2719403005 Cr-Commit-Position: refs/heads/master@{#453728} Committed: https://chromium.googlesource.com/chromium/src/+/61822c770a48bfdaa5a5d0e3b525db37123b1ce9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -168 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java View 1 chunk +0 lines, -87 lines 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 5 chunks +21 lines, -66 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sergey Ulanov
Created Revert of Add integration tests for WebAPKs
3 years, 9 months ago (2017-02-28 22:27:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719403005/1
3 years, 9 months ago (2017-02-28 22:28:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/61822c770a48bfdaa5a5d0e3b525db37123b1ce9
3 years, 9 months ago (2017-02-28 22:30:05 UTC) #7
Sergey Ulanov
Looks like this CL is not related to the build break. Closing
3 years, 9 months ago (2017-02-28 22:31:41 UTC) #8
Sergey Ulanov
3 years, 9 months ago (2017-02-28 22:32:17 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2724543003/ by sergeyu@chromium.org.

The reason for reverting is: Build breakage not related to this CL..

Powered by Google App Engine
This is Rietveld 408576698