Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2719403002: Switching to flat_sets in HQP. (Closed)

Created:
3 years, 9 months ago by dyaroshev
Modified:
3 years, 9 months ago
Reviewers:
Peter Kasting, mpearson
CC:
chromium-reviews, jdonnelly+watch_chromium.org, Alexander Yashkin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switching to flat_sets in HQP. Also implemented a few cleanups suggested in the previous cl: https://codereview.chromium.org/2690303012/ BUG=693225 Review-Url: https://codereview.chromium.org/2719403002 Cr-Commit-Position: refs/heads/master@{#454566} Committed: https://chromium.googlesource.com/chromium/src/+/246ebe8f2a857270c6a256493e2244babf257c00

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review, round 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -34 lines) Patch
M components/omnibox/browser/in_memory_url_index_types.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M components/omnibox/browser/url_index_private_data.cc View 1 4 chunks +24 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dyaroshev
@pkasting - I'm not 100% sure that you see this issue - it's marked as ...
3 years, 9 months ago (2017-03-02 22:43:18 UTC) #4
Peter Kasting
On 2017/03/02 22:43:18, dyaroshev wrote: > @pkasting - I'm not 100% sure that you see ...
3 years, 9 months ago (2017-03-02 22:52:29 UTC) #5
Peter Kasting
LGTM https://codereview.chromium.org/2719403002/diff/1/components/omnibox/browser/url_index_private_data.cc File components/omnibox/browser/url_index_private_data.cc (right): https://codereview.chromium.org/2719403002/diff/1/components/omnibox/browser/url_index_private_data.cc#newcode487 components/omnibox/browser/url_index_private_data.cc:487: if (term_history_set.empty()) { Nit: No {}
3 years, 9 months ago (2017-03-02 22:54:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719403002/20001
3 years, 9 months ago (2017-03-03 10:15:58 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 11:19:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/246ebe8f2a857270c6a256493e22...

Powered by Google App Engine
This is Rietveld 408576698