Switching to flat_sets in HQP.

Switching to flat_sets in HQP.
Also implemented a few cleanups suggested in the previous cl:
https://codereview.chromium.org/2690303012/

BUG=693225
Review-Url: https://codereview.chromium.org/2719403002
Cr-Commit-Position: refs/heads/master@{#454566}
Committed: https://chromium.googlesource.com/chromium/src/+/246ebe8f2a857270c6a256493e2244babf257c00

[dyaroshev, 2017-02-28 19:11:10]

Description was changed from

==========
Switching to using flat_sets.
Also implemented a few cleanups suggested in the previous cl:
https://codereview.chromium.org/2690303012/

BUG=693225
==========

to

==========
Switching to using flat_sets.
Also implemented a few cleanups suggested in the previous cl:
https://codereview.chromium.org/2690303012/

BUG=693225
==========

[dyaroshev, 2017-02-28 19:11:10]

dyaroshev@yandex-team.ru changed reviewers:
+ mpearson@google.com, pkasting@chromium.org

[dyaroshev, 2017-03-01 16:13:37]

Description was changed from

==========
Switching to using flat_sets.
Also implemented a few cleanups suggested in the previous cl:
https://codereview.chromium.org/2690303012/

BUG=693225
==========

to

==========
Switching to flat_sets in HQP.
Also implemented a few cleanups suggested in the previous cl:
https://codereview.chromium.org/2690303012/

BUG=693225
==========

[dyaroshev, 2017-03-02 22:43:18]

@pkasting - I'm not 100% sure that you see this issue - it's marked as "unsent"
for some reason.
Can you please let me know that you see this but busy or smth.

https://codereview.chromium.org/2719403002/diff/1/components/omnibox/browser/...
File components/omnibox/browser/in_memory_url_index_types.h (right):

https://codereview.chromium.org/2719403002/diff/1/components/omnibox/browser/...
components/omnibox/browser/in_memory_url_index_types.h:11: #include <set>
Check if <set> can be removed.

[Peter Kasting, 2017-03-02 22:52:29]

On 2017/03/02 22:43:18, dyaroshev wrote:
> @pkasting - I'm not 100% sure that you see this issue - it's marked as
"unsent"
> for some reason.
> Can you please let me know that you see this but busy or smth.

I had not seen it until you sent this.

Setting a reviewer, on its own, will not notify them that something is ready for
review.  You must always manually "Send message" (usually with an empty message)
to provide an initial notification.

[Peter Kasting, 2017-03-02 22:54:33]

LGTM

https://codereview.chromium.org/2719403002/diff/1/components/omnibox/browser/...
File components/omnibox/browser/url_index_private_data.cc (right):

https://codereview.chromium.org/2719403002/diff/1/components/omnibox/browser/...
components/omnibox/browser/url_index_private_data.cc:487: if
(term_history_set.empty()) {
Nit: No {}

[dyaroshev, 2017-03-03 10:15:49]

The CQ bit was checked by dyaroshev@yandex-team.ru

[dyaroshev, 2017-03-03 10:15:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2719403002/#ps20001
(title: "Review, round 1.")

[commit-bot: I haz the power, 2017-03-03 10:15:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 11:18:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488536149748540,
"parent_rev": "f2dcc909a45160613a7ebb5717ec5b6a93cfdce3", "commit_rev":
"246ebe8f2a857270c6a256493e2244babf257c00"}

[commit-bot: I haz the power, 2017-03-03 11:19:05]

Description was changed from

==========
Switching to flat_sets in HQP.
Also implemented a few cleanups suggested in the previous cl:
https://codereview.chromium.org/2690303012/

BUG=693225
==========

to

==========
Switching to flat_sets in HQP.
Also implemented a few cleanups suggested in the previous cl:
https://codereview.chromium.org/2690303012/

BUG=693225

Review-Url: https://codereview.chromium.org/2719403002
Cr-Commit-Position: refs/heads/master@{#454566}
Committed:
https://chromium.googlesource.com/chromium/src/+/246ebe8f2a857270c6a256493e22...
==========

[commit-bot: I haz the power, 2017-03-03 11:19:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/246ebe8f2a857270c6a256493e22...