Get visibility into stability file accumulation

Get visibility into stability file accumulation

While testing the current code, I noticed a stability file that is
missing version details nevers gets uploaded or deleted.

This CL:
- treats writedump failures as non-recoverable and deletes the file
- introduces a metric for the number of stability files

BUG=691595
Review-Url: https://codereview.chromium.org/2719343002
Cr-Commit-Position: refs/heads/master@{#454078}
Committed: https://chromium.googlesource.com/chromium/src/+/d348bbd2a92cc6e784868019bc2a1822e2437c59

[manzagop (departed), 2017-02-28 15:36:51]

manzagop@chromium.org changed reviewers:
+ siggi@chromium.org

[manzagop (departed), 2017-02-28 15:36:52]

Hi Siggi,

Looks like Brian is OOO this week. Could you have a look?

Thanks!

Pierre

[manzagop (departed), 2017-02-28 15:37:00]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 15:37:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2017-02-28 15:45:41]

lgtm with a nit on the use of LOG

https://codereview.chromium.org/2719343002/diff/1/components/browser_watcher/...
File components/browser_watcher/postmortem_report_collector.cc (right):

https://codereview.chromium.org/2719343002/diff/1/components/browser_watcher/...
components/browser_watcher/postmortem_report_collector.cc:248: LOG(ERROR) <<
"PrepareNewCrashReport failed";
Out of curiosity - how are these LOGs useful? Have you ever retrieved a log from
the field? Maybe it's better to use DLOG, and avoid bloating our shipped
binaries?

[manzagop (departed), 2017-02-28 16:07:40]

Thanks!

https://codereview.chromium.org/2719343002/diff/1/components/browser_watcher/...
File components/browser_watcher/postmortem_report_collector.cc (right):

https://codereview.chromium.org/2719343002/diff/1/components/browser_watcher/...
components/browser_watcher/postmortem_report_collector.cc:248: LOG(ERROR) <<
"PrepareNewCrashReport failed";
On 2017/02/28 15:45:41, Sigurður Ásgeirsson wrote:
> Out of curiosity - how are these LOGs useful? Have you ever retrieved a log
from
> the field? Maybe it's better to use DLOG, and avoid bloating our shipped
> binaries?

Done.

[manzagop (departed), 2017-02-28 16:08:26]

manzagop@chromium.org changed reviewers:
+ jwd@chromium.org

[manzagop (departed), 2017-02-28 16:08:26]

Hi Jesse!

Could you have a metrics OWNERS' look?
Thanks!

Pierre

[manzagop (departed), 2017-02-28 16:08:32]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 16:08:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 17:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 17:22:21]

Dry run: This issue passed the CQ dry run.

[jwd, 2017-03-01 20:07:46]

LGTM with comment.

https://codereview.chromium.org/2719343002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2719343002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:374: +<histogram
name="ActivityTracker.Collect.StabilityFileCount">
units="count"

[manzagop (departed), 2017-03-01 21:18:48]

Thanks! Going ahead with submission.

https://codereview.chromium.org/2719343002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2719343002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:374: +<histogram
name="ActivityTracker.Collect.StabilityFileCount">
On 2017/03/01 20:07:46, jwd wrote:
> units="count"

Done.

[manzagop (departed), 2017-03-01 21:19:17]

The CQ bit was checked by manzagop@chromium.org

[manzagop (departed), 2017-03-01 21:19:17]

The patchset sent to the CQ was uploaded after l-g-t-m from siggi@chromium.org,
jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2719343002/#ps40001
(title: "jwd comment")

[commit-bot: I haz the power, 2017-03-01 21:20:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:47:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488403157217130,
"parent_rev": "4de4918b64f6fc0bdd4022d452bd693a785d6074", "commit_rev":
"d348bbd2a92cc6e784868019bc2a1822e2437c59"}

[commit-bot: I haz the power, 2017-03-01 22:48:28]

Description was changed from

==========
Get visibility into stability file accumulation

While testing the current code, I noticed a stability file that is
missing version details nevers gets uploaded or deleted.

This CL:
- treats writedump failures as non-recoverable and deletes the file
- introduces a metric for the number of stability files

BUG=691595
==========

to

==========
Get visibility into stability file accumulation

While testing the current code, I noticed a stability file that is
missing version details nevers gets uploaded or deleted.

This CL:
- treats writedump failures as non-recoverable and deletes the file
- introduces a metric for the number of stability files

BUG=691595

Review-Url: https://codereview.chromium.org/2719343002
Cr-Commit-Position: refs/heads/master@{#454078}
Committed:
https://chromium.googlesource.com/chromium/src/+/d348bbd2a92cc6e784868019bc2a...
==========

[commit-bot: I haz the power, 2017-03-01 22:48:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d348bbd2a92cc6e784868019bc2a...