Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2719283002: Deprecate memory coordinator v0 related histograms (Closed)

Created:
3 years, 9 months ago by bashi
Modified:
3 years, 9 months ago
Reviewers:
haraken, Ilya Sherman
CC:
chromium-reviews, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate memory coordinator v0 related histograms We've been running an experiment for memory coordinator. Based on the results from the experiment, I've started changing internal design of memory coordinator and most histograms related to memory coordinator won't make sense anymore. BUG=696844 Review-Url: https://codereview.chromium.org/2719283002 Cr-Commit-Position: refs/heads/master@{#453512} Committed: https://chromium.googlesource.com/chromium/src/+/2451a9a11f87ce84cd6f280984b05251d7a2093d

Patch Set 1 #

Patch Set 2 : remove includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -131 lines) Patch
M content/browser/memory/memory_coordinator_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 1 6 chunks +1 line, -106 lines 0 comments Download
M content/browser/memory/memory_monitor_android.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 6 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
bashi
PTAL
3 years, 9 months ago (2017-02-28 03:21:27 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-02-28 03:33:55 UTC) #5
Ilya Sherman
lgtm
3 years, 9 months ago (2017-02-28 03:36:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719283002/20001
3 years, 9 months ago (2017-02-28 05:10:16 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 05:17:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2451a9a11f87ce84cd6f280984b0...

Powered by Google App Engine
This is Rietveld 408576698