Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: net/ssl/ssl_config_service.cc

Issue 2719273002: Disable commonName matching for certificates (Closed)
Patch Set: Update macOS Keychain Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ssl/ssl_config_service.cc
diff --git a/net/ssl/ssl_config_service.cc b/net/ssl/ssl_config_service.cc
index 2b4388efac58dc7d86c76ef6f74b7602636aa66e..c566271b4f664216f6729deadc8e34308d25be2b 100644
--- a/net/ssl/ssl_config_service.cc
+++ b/net/ssl/ssl_config_service.cc
@@ -88,16 +88,19 @@ void SSLConfigService::ProcessConfigUpdate(const SSLConfig& orig_config,
bool config_changed =
std::tie(orig_config.rev_checking_enabled,
orig_config.rev_checking_required_local_anchors,
- orig_config.sha1_local_anchors_enabled, orig_config.version_min,
- orig_config.version_max, orig_config.disabled_cipher_suites,
+ orig_config.sha1_local_anchors_enabled,
+ orig_config.common_name_fallback_local_anchors_enabled,
+ orig_config.version_min, orig_config.version_max,
+ orig_config.disabled_cipher_suites,
orig_config.channel_id_enabled, orig_config.false_start_enabled,
orig_config.require_ecdhe) !=
mattm 2017/03/01 23:56:47 nit: maybe rename orig_config to old_config so it
Ryan Sleevi 2017/03/02 00:15:31 Excellent suggestion!
std::tie(new_config.rev_checking_enabled,
new_config.rev_checking_required_local_anchors,
- new_config.sha1_local_anchors_enabled, new_config.version_min,
- new_config.version_max, new_config.disabled_cipher_suites,
- new_config.channel_id_enabled, new_config.false_start_enabled,
- new_config.require_ecdhe);
+ new_config.sha1_local_anchors_enabled,
+ new_config.common_name_fallback_local_anchors_enabled,
+ new_config.version_min, new_config.version_max,
+ new_config.disabled_cipher_suites, new_config.channel_id_enabled,
+ new_config.false_start_enabled, new_config.require_ecdhe);
if (config_changed)
NotifySSLConfigChange();

Powered by Google App Engine
This is Rietveld 408576698