Disable commonName matching for certificates

net/ssl/ssl_config_service_unittest.cc

Index: net/ssl/ssl_config_service_unittest.cc
diff --git a/net/ssl/ssl_config_service_unittest.cc b/net/ssl/ssl_config_service_unittest.cc
index 72041ff2412858d4cbee0e0aa868314ce17fe20d..a4d4f9f6a7b217ef64479108813d74e21267aa39 100644
--- a/net/ssl/ssl_config_service_unittest.cc
+++ b/net/ssl/ssl_config_service_unittest.cc
@@ -67,6 +67,7 @@ TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {
   initial_config.rev_checking_enabled = true;
   initial_config.rev_checking_required_local_anchors = false;
   initial_config.sha1_local_anchors_enabled = true;
+  initial_config.common_name_fallback_local_anchors_enabled = true;
   initial_config.false_start_enabled = false;
   initial_config.require_ecdhe = false;
   initial_config.version_min = SSL_PROTOCOL_VERSION_TLS1;
@@ -90,6 +91,10 @@ TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {
   EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
   mock_service->SetSSLConfig(initial_config);
 
+  initial_config.common_name_fallback_local_anchors_enabled = false;
+  EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
+  mock_service->SetSSLConfig(initial_config);

[mattm, 2017/03/01 23:56:47]

I wonder if there should be a Mock::VerifyAndClearExpectations(&observer) call
after each of these sections?

[Ryan Sleevi, 2017/03/02 00:15:31]

We could, but I think we're fine as is, because the overall test would fail, and
it indicates where the expectation was set - which also indicates which
expectation failed.

+
   initial_config.false_start_enabled = true;
   EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
   mock_service->SetSSLConfig(initial_config);