Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/ssl/ssl_config_service.cc

Issue 2719273002: Disable commonName matching for certificates (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/spdy/spdy_session.cc ('K') | « net/ssl/ssl_config.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_config_service.cc
diff --git a/net/ssl/ssl_config_service.cc b/net/ssl/ssl_config_service.cc
index c80113c4e99315dfd999e4499ff6c4608662ad7e..f34d0513a05a7af9f7fc307afd9c39fc17763a44 100644
--- a/net/ssl/ssl_config_service.cc
+++ b/net/ssl/ssl_config_service.cc
@@ -87,6 +87,10 @@ void SSLConfigService::ProcessConfigUpdate(const SSLConfig& orig_config,
(orig_config.rev_checking_enabled != new_config.rev_checking_enabled) ||
(orig_config.rev_checking_required_local_anchors !=
new_config.rev_checking_required_local_anchors) ||
+ (orig_config.sha1_local_anchors_enabled !=
+ new_config.sha1_local_anchors_enabled) ||
Ryan Sleevi 2017/02/28 02:16:58 I'm going to split this part out into a separate C
mattm 2017/02/28 18:50:48 doh, thanks.
+ (orig_config.common_name_fallback_local_anchors_enabled !=
+ new_config.common_name_fallback_local_anchors_enabled) ||
(orig_config.version_min != new_config.version_min) ||
(orig_config.version_max != new_config.version_max) ||
(orig_config.disabled_cipher_suites !=
« net/spdy/spdy_session.cc ('K') | « net/ssl/ssl_config.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698