Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Side by Side Diff: net/ssl/ssl_config_service.cc

Issue 2719273002: Disable commonName matching for certificates (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/ssl/ssl_config_service.h" 5 #include "net/ssl/ssl_config_service.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/synchronization/lock.h" 8 #include "base/synchronization/lock.h"
9 #include "net/ssl/ssl_config_service_defaults.h" 9 #include "net/ssl/ssl_config_service_defaults.h"
10 10
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 80
81 SSLConfigService::~SSLConfigService() { 81 SSLConfigService::~SSLConfigService() {
82 } 82 }
83 83
84 void SSLConfigService::ProcessConfigUpdate(const SSLConfig& orig_config, 84 void SSLConfigService::ProcessConfigUpdate(const SSLConfig& orig_config,
85 const SSLConfig& new_config) { 85 const SSLConfig& new_config) {
86 bool config_changed = 86 bool config_changed =
87 (orig_config.rev_checking_enabled != new_config.rev_checking_enabled) || 87 (orig_config.rev_checking_enabled != new_config.rev_checking_enabled) ||
88 (orig_config.rev_checking_required_local_anchors != 88 (orig_config.rev_checking_required_local_anchors !=
89 new_config.rev_checking_required_local_anchors) || 89 new_config.rev_checking_required_local_anchors) ||
90 (orig_config.sha1_local_anchors_enabled !=
91 new_config.sha1_local_anchors_enabled) ||
Ryan Sleevi 2017/02/28 02:16:58 I'm going to split this part out into a separate C
mattm 2017/02/28 18:50:48 doh, thanks.
92 (orig_config.common_name_fallback_local_anchors_enabled !=
93 new_config.common_name_fallback_local_anchors_enabled) ||
90 (orig_config.version_min != new_config.version_min) || 94 (orig_config.version_min != new_config.version_min) ||
91 (orig_config.version_max != new_config.version_max) || 95 (orig_config.version_max != new_config.version_max) ||
92 (orig_config.disabled_cipher_suites != 96 (orig_config.disabled_cipher_suites !=
93 new_config.disabled_cipher_suites) || 97 new_config.disabled_cipher_suites) ||
94 (orig_config.channel_id_enabled != new_config.channel_id_enabled) || 98 (orig_config.channel_id_enabled != new_config.channel_id_enabled) ||
95 (orig_config.false_start_enabled != new_config.false_start_enabled) || 99 (orig_config.false_start_enabled != new_config.false_start_enabled) ||
96 (orig_config.require_ecdhe != new_config.require_ecdhe); 100 (orig_config.require_ecdhe != new_config.require_ecdhe);
97 101
98 if (config_changed) 102 if (config_changed)
99 NotifySSLConfigChange(); 103 NotifySSLConfigChange();
100 } 104 }
101 105
102 } // namespace net 106 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698