Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2719253003: Spruce up "ChromeVox on Desktop Linux" docs (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Spruce up "ChromeVox on Desktop Linux" docs TBR=dmazzoni@chromium.org BUG=none NOTRY=true Review-Url: https://codereview.chromium.org/2719253003 Cr-Commit-Position: refs/heads/master@{#454199} Committed: https://chromium.googlesource.com/chromium/src/+/9e590b21b73b456000dd8bf506bb64919252283d

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -37 lines) Patch
M docs/accessibility/chromevox_on_desktop_linux.md View 2 chunks +42 lines, -37 lines 4 comments Download

Messages

Total messages: 10 (5 generated)
Dan Beam
https://codereview.chromium.org/2719253003/diff/1/docs/accessibility/chromevox_on_desktop_linux.md File docs/accessibility/chromevox_on_desktop_linux.md (left): https://codereview.chromium.org/2719253003/diff/1/docs/accessibility/chromevox_on_desktop_linux.md#oldcode18 docs/accessibility/chromevox_on_desktop_linux.md:18: ```> gn args out/ChromeOSRelease``` cros in the rest of ...
3 years, 9 months ago (2017-02-28 22:09:36 UTC) #1
Dan Beam
TBR'ing as per doc instructions sent out by brettw@
3 years, 9 months ago (2017-03-02 07:04:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719253003/1
3 years, 9 months ago (2017-03-02 07:06:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9e590b21b73b456000dd8bf506bb64919252283d
3 years, 9 months ago (2017-03-02 07:12:07 UTC) #9
dmazzoni
3 years, 9 months ago (2017-03-02 07:13:13 UTC) #10
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698