Fix browser window shelf id init; re-enable browser test.

Fix browser window shelf id init; re-enable browser test.

Initialize browser window shelf ids on shortcut creation.
This was only happening on page load, etc. (after shortcut creation).

Re-enable ShelfAppBrowserTest.MatchingShelfIDandActiveTab.
I'm not sure what caused/exacerbated the recent flakiness.

BUG=694941
TEST=Automated; no behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2719233002
Cr-Commit-Position: refs/heads/master@{#453469}
Committed: https://chromium.googlesource.com/chromium/src/+/8efedb10c4620871e01944c79c294be9ef04db07

[msw, 2017-02-27 23:13:25]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 23:13:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-02-27 23:16:37]

Description was changed from

==========
Fix browser window shelf id init; re-enable flaky test.

BUG=694941
==========

to

==========
Fix browser window shelf id init; re-enable flaky test.

Initialize browser window shelf ids on shortcut creation.
This was only happening on page load, etc. (after shortcut creation).

Re-enable ShelfAppBrowserTest.MatchingShelfIDandActiveTab.
I'm not sure what caused/exacerbated the recent flakiness.

BUG=694941
TEST=Automated; no behavior changes.
R=jamescook@chromium.org
==========

[msw, 2017-02-27 23:16:37]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2017-02-27 23:17:20]

Description was changed from

==========
Fix browser window shelf id init; re-enable flaky test.

Initialize browser window shelf ids on shortcut creation.
This was only happening on page load, etc. (after shortcut creation).

Re-enable ShelfAppBrowserTest.MatchingShelfIDandActiveTab.
I'm not sure what caused/exacerbated the recent flakiness.

BUG=694941
TEST=Automated; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
Fix browser window shelf id init; re-enable browser test.

Initialize browser window shelf ids on shortcut creation.
This was only happening on page load, etc. (after shortcut creation).

Re-enable ShelfAppBrowserTest.MatchingShelfIDandActiveTab.
I'm not sure what caused/exacerbated the recent flakiness.

BUG=694941
TEST=Automated; no behavior changes.
R=jamescook@chromium.org
==========

[msw, 2017-02-27 23:38:34]

Hey James, please take a look; thanks!

[James Cook, 2017-02-27 23:51:21]

LGTM. I wonder if this became flaky due to async shelf creation, so sometimes a
browser window might open before the shelf was created.

[commit-bot: I haz the power, 2017-02-28 00:50:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 00:50:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2017-02-28 01:26:44]

On 2017/02/27 23:51:21, James Cook wrote:
> I wonder if this became flaky due to async shelf creation, so sometimes a
> browser window might open before the shelf was created.

That's possible - I did see browser windows being created before the shelf in
local testing. I added a shelf delegate null check in the latest patch set; lmk
if you have any concerns.

[msw, 2017-02-28 01:26:49]

The CQ bit was checked by msw@chromium.org

[msw, 2017-02-28 01:26:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2719233002/#ps40001
(title: "Add shelf_delegate null check.")

[commit-bot: I haz the power, 2017-02-28 01:27:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 02:31:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488245209022760,
"parent_rev": "f049d39bddb99f0338f98342e2c79e11ace4574c", "commit_rev":
"8efedb10c4620871e01944c79c294be9ef04db07"}

[commit-bot: I haz the power, 2017-02-28 02:40:27]

Description was changed from

==========
Fix browser window shelf id init; re-enable browser test.

Initialize browser window shelf ids on shortcut creation.
This was only happening on page load, etc. (after shortcut creation).

Re-enable ShelfAppBrowserTest.MatchingShelfIDandActiveTab.
I'm not sure what caused/exacerbated the recent flakiness.

BUG=694941
TEST=Automated; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
Fix browser window shelf id init; re-enable browser test.

Initialize browser window shelf ids on shortcut creation.
This was only happening on page load, etc. (after shortcut creation).

Re-enable ShelfAppBrowserTest.MatchingShelfIDandActiveTab.
I'm not sure what caused/exacerbated the recent flakiness.

BUG=694941
TEST=Automated; no behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2719233002
Cr-Commit-Position: refs/heads/master@{#453469}
Committed:
https://chromium.googlesource.com/chromium/src/+/8efedb10c4620871e01944c79c29...
==========

[commit-bot: I haz the power, 2017-02-28 02:40:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8efedb10c4620871e01944c79c29...

[James Cook, 2017-02-28 14:59:19]

still lgtm