Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 271923002: Remove VideoRenderer::Pause() as it serves no real purpose. (Closed)

Created:
6 years, 7 months ago by scherkus (not reviewing)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove VideoRenderer::Pause() as it serves no real purpose. Flush() already accomplishes pausing by releasing all data and not reading until Preroll() is called. BUG=110814 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269675

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -47 lines) Patch
M media/base/mock_filters.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/base/pipeline.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/pipeline_unittest.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M media/base/video_renderer.h View 1 chunk +2 lines, -5 lines 0 comments Download
M media/filters/video_renderer_impl.h View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M media/filters/video_renderer_impl.cc View 1 2 3 chunks +2 lines, -11 lines 0 comments Download
M media/filters/video_renderer_impl_unittest.cc View 7 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
scherkus (not reviewing)
working towards that pipeline-controlled rebuffer stuff we talked about yesterday first things first is removing ...
6 years, 7 months ago (2014-05-08 17:59:46 UTC) #1
acolwell GONE FROM CHROMIUM
watch out folks. He's got the code flame thrower out. LGTM
6 years, 7 months ago (2014-05-08 18:43:01 UTC) #2
xhwang
Good catch! Who doesn't like simpler code? On Thu, May 8, 2014 at 11:43 AM, ...
6 years, 7 months ago (2014-05-08 20:02:37 UTC) #3
scherkus (not reviewing)
On 2014/05/08 20:02:37, xhwang wrote: > Good catch! Who doesn't like simpler code? Said nobody, ...
6 years, 7 months ago (2014-05-08 20:04:16 UTC) #4
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 7 months ago (2014-05-10 07:19:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/271923002/40001
6 years, 7 months ago (2014-05-10 07:20:22 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 07:41:24 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 07:44:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67021)
6 years, 7 months ago (2014-05-10 07:44:28 UTC) #9
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 7 months ago (2014-05-10 20:06:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/271923002/60001
6 years, 7 months ago (2014-05-10 20:07:49 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:25:41 UTC) #12
Message was sent while issue was closed.
Change committed as 269675

Powered by Google App Engine
This is Rietveld 408576698