Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: media/filters/video_renderer_impl.h

Issue 271923002: Remove VideoRenderer::Pause() as it serves no real purpose. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/video_renderer.h ('k') | media/filters/video_renderer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/video_renderer_impl.h
diff --git a/media/filters/video_renderer_impl.h b/media/filters/video_renderer_impl.h
index cf4061b03f6881d8a15a1c266e71df9277ecba54..4fef25d55c6ea405e710711e144392e1fe44fcee 100644
--- a/media/filters/video_renderer_impl.h
+++ b/media/filters/video_renderer_impl.h
@@ -66,7 +66,6 @@ class MEDIA_EXPORT VideoRendererImpl
const TimeDeltaCB& get_time_cb,
const TimeDeltaCB& get_duration_cb) OVERRIDE;
virtual void Play(const base::Closure& callback) OVERRIDE;
- virtual void Pause(const base::Closure& callback) OVERRIDE;
virtual void Flush(const base::Closure& callback) OVERRIDE;
virtual void Preroll(base::TimeDelta time,
const PipelineStatusCB& cb) OVERRIDE;
@@ -164,13 +163,13 @@ class MEDIA_EXPORT VideoRendererImpl
// | | Preroll() or upon ^
// | V got first frame [kFlushing]
// | [kPrerolling] ^
- // | | | Flush()
+ // | | |
// | V Got enough frames |
- // | [kPrerolled]---------------------->[kPaused]
- // | | Pause() ^
+ // | [kPrerolled]--------------------------|
+ // | | Flush() ^
// | V Play() |
// | [kPlaying]---------------------------|
- // | Pause() ^ Pause()
+ // | Flush() ^ Flush()
// | |
// +-----> [kStopped] [Any state other than]
// [ kUninitialized ]
@@ -180,7 +179,6 @@ class MEDIA_EXPORT VideoRendererImpl
kUninitialized,
kInitializing,
kPrerolled,
- kPaused,
kFlushing,
kFlushed,
kPrerolling,
« no previous file with comments | « media/base/video_renderer.h ('k') | media/filters/video_renderer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698