Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2719183003: Annotee: Export Coordinator link generator. (Closed)

Created:
3 years, 9 months ago by dnj
Modified:
3 years, 9 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Annotee: Export Coordinator link generator. Export the Coordinator link generator type. It will be used by Kitchen's embeded Annotee processor to generate links. Update it to take advantage of the new (to it) "viewer" package for homogenous link generation. BUG=chromium:694911 TEST=None R=nodir@chromium.org Review-Url: https://codereview.chromium.org/2719183003 Committed: https://github.com/luci/luci-go/commit/50c849215ac7d0bea13833b1524272dac733d890

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -50 lines) Patch
A logdog/client/annotee/link_generator.go View 1 chunk +41 lines, -0 lines 2 comments Download
M logdog/client/annotee/processor.go View 1 chunk +0 lines, -8 lines 0 comments Download
D logdog/client/cmd/logdog_annotee/link.go View 1 chunk +0 lines, -37 lines 0 comments Download
M logdog/client/cmd/logdog_annotee/main.go View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dnj
3 years, 9 months ago (2017-02-28 00:11:25 UTC) #1
nodir
lgtm https://codereview.chromium.org/2719183003/diff/1/logdog/client/annotee/link_generator.go File logdog/client/annotee/link_generator.go (right): https://codereview.chromium.org/2719183003/diff/1/logdog/client/annotee/link_generator.go#newcode15 logdog/client/annotee/link_generator.go:15: // GetLink returns a link for the specified ...
3 years, 9 months ago (2017-02-28 00:22:38 UTC) #2
dnj
https://codereview.chromium.org/2719183003/diff/1/logdog/client/annotee/link_generator.go File logdog/client/annotee/link_generator.go (right): https://codereview.chromium.org/2719183003/diff/1/logdog/client/annotee/link_generator.go#newcode15 logdog/client/annotee/link_generator.go:15: // GetLink returns a link for the specified aggregate ...
3 years, 9 months ago (2017-02-28 00:24:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719183003/1
3 years, 9 months ago (2017-02-28 00:24:50 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 00:30:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/50c849215ac7d0bea13833b1524272dac733d890

Powered by Google App Engine
This is Rietveld 408576698