Write mojom and StructTraits for display::GammaRampRGBEntry

Write mojom and StructTraits for display::GammaRampRGBEntry.

We need a mojom and StructTraits for GammaRampRGBEntry for 
communication between the gpu process and the mus-ws process for Ozone 
GBM.

BUG=696638
Review-Url: https://codereview.chromium.org/2719183002
Cr-Commit-Position: refs/heads/master@{#455303}
Committed: https://chromium.googlesource.com/chromium/src/+/3aa23b6bd85fa5bb3b96e23fb08f1d400a75747e

[thanhph1, 2017-02-27 21:55:12]

The CQ bit was checked by thanhph@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 21:55:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph1, 2017-02-27 22:22:34]

Description was changed from

==========
add mojo, struct traits for display::GammaRampRGBEntry

BUG=696638
==========

to

==========
Write mojom and StructTraits for display::GammaRampRGBEntry.

We need a mojom and StructTraits for GammaRampRGBEntry for communication between
the gpu process to the mus-ws process for Ozone GBM.

BUG=696638
==========

[thanhph1, 2017-02-27 22:24:34]

thanhph@google.com changed reviewers:
+ kylechar@chromium.org, rjkroege@chromium.org

[thanhph1, 2017-02-27 22:24:35]

Hi Kyle, 

Can you review my cl?

Thanks,
Thanh.

[thanhph1, 2017-02-27 22:25:14]

Description was changed from

==========
Write mojom and StructTraits for display::GammaRampRGBEntry.

We need a mojom and StructTraits for GammaRampRGBEntry for communication between
the gpu process to the mus-ws process for Ozone GBM.

BUG=696638
==========

to

==========
Write mojom and StructTraits for display::GammaRampRGBEntry.

We need a mojom and StructTraits for GammaRampRGBEntry for 
communication between the gpu process to the mus-ws process for Ozone 
GBM.

BUG=696638
==========

[thanhph1, 2017-02-27 22:29:28]

Description was changed from

==========
Write mojom and StructTraits for display::GammaRampRGBEntry.

We need a mojom and StructTraits for GammaRampRGBEntry for 
communication between the gpu process to the mus-ws process for Ozone 
GBM.

BUG=696638
==========

to

==========
Write mojom and StructTraits for display::GammaRampRGBEntry.

We need a mojom and StructTraits for GammaRampRGBEntry for 
communication between the gpu process and the mus-ws process for Ozone 
GBM.

BUG=696638
==========

[kylechar, 2017-02-27 22:33:37]

https://codereview.chromium.org/2719183002/diff/1/ui/display/mojo/display_str...
File ui/display/mojo/display_struct_traits_unittest.cc (right):

https://codereview.chromium.org/2719183002/diff/1/ui/display/mojo/display_str...
ui/display/mojo/display_struct_traits_unittest.cc:230: GammaRampRGBEntry input,
output;
Can you make this const? It's a struct so you should be able to something like:

const GammaRampRGBEntry input{259, 81, 16};

https://codereview.chromium.org/2719183002/diff/1/ui/display/mojo/display_str...
ui/display/mojo/display_struct_traits_unittest.cc:235:
GetTraitsTestProxy()->EchoGammaRampRGBEntry(input, &output);
Declare output down here right before you use it.

https://codereview.chromium.org/2719183002/diff/1/ui/display/mojo/gamma_ramp_...
File ui/display/mojo/gamma_ramp_rgb_entry.mojom (right):

https://codereview.chromium.org/2719183002/diff/1/ui/display/mojo/gamma_ramp_...
ui/display/mojo/gamma_ramp_rgb_entry.mojom:7: // Corresponds to
display::GammaRampRGBEntry
Period.

[thanhph1, 2017-02-27 22:43:08]

The CQ bit was checked by thanhph@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 22:43:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 00:05:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 00:05:12]

Dry run: This issue passed the CQ dry run.

[thanhph1, 2017-02-28 13:12:01]

Thanks Kyle. Please review my new cl.

Thanh.

https://codereview.chromium.org/2719183002/diff/1/ui/display/mojo/display_str...
File ui/display/mojo/display_struct_traits_unittest.cc (right):

https://codereview.chromium.org/2719183002/diff/1/ui/display/mojo/display_str...
ui/display/mojo/display_struct_traits_unittest.cc:230: GammaRampRGBEntry input,
output;
On 2017/02/27 22:33:37, kylechar wrote:
> Can you make this const? It's a struct so you should be able to something
like:
> 
> const GammaRampRGBEntry input{259, 81, 16};

Done, cool!

https://codereview.chromium.org/2719183002/diff/1/ui/display/mojo/display_str...
ui/display/mojo/display_struct_traits_unittest.cc:235:
GetTraitsTestProxy()->EchoGammaRampRGBEntry(input, &output);
On 2017/02/27 22:33:37, kylechar wrote:
> Declare output down here right before you use it.

Done.

https://codereview.chromium.org/2719183002/diff/1/ui/display/mojo/gamma_ramp_...
File ui/display/mojo/gamma_ramp_rgb_entry.mojom (right):

https://codereview.chromium.org/2719183002/diff/1/ui/display/mojo/gamma_ramp_...
ui/display/mojo/gamma_ramp_rgb_entry.mojom:7: // Corresponds to
display::GammaRampRGBEntry
On 2017/02/27 22:33:37, kylechar wrote:
> Period.

Done.

[kylechar, 2017-02-28 13:42:55]

lgtm.

[rjkroege, 2017-03-01 15:32:16]

lgtm

[thanhph1, 2017-03-01 15:47:23]

thanhph@google.com changed reviewers:
+ oshima@chromium.org, tsepez@chromium.org

[thanhph1, 2017-03-01 15:47:24]

oshima@: Hi Mitsuru, please review changes my ui/display.

tsepez@: Hi Tom, please review my mojom files.

Thanks,
Thanh.

[thanhph1, 2017-03-01 15:47:51]

On 2017/02/28 13:42:55, kylechar wrote:
> lgtm.

[Tom Sepez, 2017-03-06 22:35:03]

lgtm

[thanhph, 2017-03-07 21:36:31]

thanhph@chromium.org changed reviewers:
+ derat@chromium.org
- oshima@chromium.org

[thanhph, 2017-03-07 21:37:12]

Hi Dan,

Could you review another of my CL?

Thanks,
Thanh.

[Daniel Erat, 2017-03-07 22:31:53]

lgtm for ui/display/

[thanhph, 2017-03-07 22:46:30]

The CQ bit was checked by thanhph@chromium.org

[commit-bot: I haz the power, 2017-03-07 22:47:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 00:09:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488926790467410,
"parent_rev": "0e2f711d53961feb53d460fd96073ad47ef4a366", "commit_rev":
"3aa23b6bd85fa5bb3b96e23fb08f1d400a75747e"}

[commit-bot: I haz the power, 2017-03-08 00:10:06]

Description was changed from

==========
Write mojom and StructTraits for display::GammaRampRGBEntry.

We need a mojom and StructTraits for GammaRampRGBEntry for 
communication between the gpu process and the mus-ws process for Ozone 
GBM.

BUG=696638
==========

to

==========
Write mojom and StructTraits for display::GammaRampRGBEntry.

We need a mojom and StructTraits for GammaRampRGBEntry for 
communication between the gpu process and the mus-ws process for Ozone 
GBM.

BUG=696638

Review-Url: https://codereview.chromium.org/2719183002
Cr-Commit-Position: refs/heads/master@{#455303}
Committed:
https://chromium.googlesource.com/chromium/src/+/3aa23b6bd85fa5bb3b96e23fb08f...
==========

[commit-bot: I haz the power, 2017-03-08 00:10:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3aa23b6bd85fa5bb3b96e23fb08f...

[thanhph, 2017-03-08 00:21:26]

On 2017/03/07 22:31:53, Daniel Erat wrote:
> lgtm for ui/display/

Thanks Daniel!

Thanh.