Animate window control changes in TouchView

ash/frame/default_header_painter.cc

Index: ash/frame/default_header_painter.cc
diff --git a/ash/frame/default_header_painter.cc b/ash/frame/default_header_painter.cc
index fd31d776e91913c78bc0c304370793280d4db70e..e8a46ef3861ce011e601500ce36af6de9fe54a62 100644
--- a/ash/frame/default_header_painter.cc
+++ b/ash/frame/default_header_painter.cc
@@ -200,8 +200,6 @@ void DefaultHeaderPainter::PaintHeader(gfx::Canvas* canvas, Mode mode) {
 }
 
 void DefaultHeaderPainter::LayoutHeader() {
-  caption_button_container_->Layout();
-
   gfx::Size caption_button_container_size =
       caption_button_container_->GetPreferredSize();
   caption_button_container_->SetBounds(
@@ -209,7 +207,7 @@ void DefaultHeaderPainter::LayoutHeader() {
       0,
       caption_button_container_size.width(),
       caption_button_container_size.height());
-
+  caption_button_container_->Layout();

[flackr, 2014/05/22 15:46:18]

Isn't there a risk that the caption button container preferred size will be
completely wrong if layout hasn't been called yet?

I could see instead updating GetPreferredSize to return the larger size if a
button is animating out.

[jonross, 2014/05/22 20:36:04]

GetPreferredSize calculates based on visibility of the components, and their
desired layout.

Layout is restricted to the bounds being set.

So this order is needed to handle a change in desired size.

On 2014/05/22 15:46:18, flackr wrote:

   if (window_icon_) {
     // Vertically center the window icon with respect to the caption button
     // container.