Animate window control changes in TouchView

ash/frame/default_header_painter.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/frame/default_header_painter.h"
 
 #include "ash/frame/caption_buttons/frame_caption_button_container_view.h"
 #include "ash/frame/header_painter_util.h"
 #include "base/debug/leak_annotations.h"
 #include "base/logging.h"  // DCHECK
@@ skipping 182 matching lines @@
     PaintHighlightForInactiveRestoredWindow(canvas);
   }
   if (frame_->widget_delegate() &&
       frame_->widget_delegate()->ShouldShowWindowTitle()) {
     PaintTitleBar(canvas);
   }
   PaintHeaderContentSeparator(canvas);
 }
 
 void DefaultHeaderPainter::LayoutHeader() {
-  caption_button_container_->Layout();
-
   gfx::Size caption_button_container_size =
       caption_button_container_->GetPreferredSize();
   caption_button_container_->SetBounds(
       view_->width() - caption_button_container_size.width(),
       0,
       caption_button_container_size.width(),
       caption_button_container_size.height());
-
+  caption_button_container_->Layout();

[flackr, 2014/05/22 15:46:18]

Isn't there a risk that the caption button container preferred size will be
completely wrong if layout hasn't been called yet?

I could see instead updating GetPreferredSize to return the larger size if a
button is animating out.

[jonross, 2014/05/22 20:36:04]

GetPreferredSize calculates based on visibility of the components, and their
desired layout.

Layout is restricted to the bounds being set.

So this order is needed to handle a change in desired size.

On 2014/05/22 15:46:18, flackr wrote:

   if (window_icon_) {
     // Vertically center the window icon with respect to the caption button
     // container.
     // Floor when computing the center of |caption_button_container_|.
     int icon_offset_y =
         caption_button_container_->height() / 2 - window_icon_size_ / 2;
     window_icon_->SetBounds(HeaderPainterUtil::GetIconXOffset(), icon_offset_y,
                             window_icon_size_, window_icon_size_);
   }
 
@@ skipping 106 matching lines @@
 
 gfx::ImageSkia* DefaultHeaderPainter::GetInactiveFrameImage() const {
   int frame_image_id = (frame_->IsMaximized() || frame_->IsFullscreen()) ?
       IDR_AURA_WINDOW_HEADER_BASE :
       IDR_AURA_WINDOW_HEADER_BASE_RESTORED_INACTIVE;
   return ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
       frame_image_id);
 }
 
 }  // namespace ash