Network traffic annotation added to usb_test_gadget_impl.

Network traffic annotation added to usb_test_gadget_impl.

Network traffic annotation is added to network request of
usb_test_gadget_impl.

BUG=656607
Review-Url: https://codereview.chromium.org/2719123003
Cr-Commit-Position: refs/heads/master@{#454583}
Committed: https://chromium.googlesource.com/chromium/src/+/d75e16c38dd0918d0f38307aacd51241ee56f318

[Ramin Halavati, 2017-02-28 13:23:56]

rhalavati@chromium.org changed reviewers:
+ asanka@chromium.org, reillyg@chromium.org

[Ramin Halavati, 2017-02-28 13:23:57]

asanka@:
Please review DEPS as owner of net.

reillyg@:
We are adding annotations to all network requests and the URLFetcher::Create
functions without annotation will be soon deprecated. Assuming that this class
is only for tests, I've added just a flag stating that it does not need
annotation. If I am wrong, please tell me to change the CL accordingly. Please
review both files, here is more details if you are interested:

We are annotating all network requests in Chromium with a new
NetworkTrafficAnnotation scheme. This allows enterprise users of Chrome to audit
the requests and configure Chrome in a way that meets their security policies
and expectations. Furthermore, it allows us to generate better debugging data in
chrome://net-internals and measure bandwidth consumption on a per-request-type
basis.

Please take a look at the protobuf scheme in:
https://cs.chromium.org/chromium/src/tools/traffic_annotation/traffic_annotat...
for the definition of the annotations.

You can find a sample annotation in:
https://cs.chromium.org/chromium/src/components/spellcheck/browser/spelling_s...

Entriprise policy options are here:
https://cs.chromium.org/chromium/src/out/Debug/gen/components/policy/proto/cl...

And more description on enterprise policy settings is here:
http://dev.chromium.org/administrators/policy-list-3

Please tell me if you need any clarifications from my side. If you want to learn
more, see:
https://docs.google.com/document/d/1FWEFTHzdqIA1wHUo_DuSpJjppW22otCMPCOA5NumhJU.

[Reilly Grant (use Gerrit), 2017-02-28 19:07:04]

lgtm

[Ramin Halavati, 2017-03-01 08:07:22]

The CQ bit was checked by rhalavati@chromium.org

[commit-bot: I haz the power, 2017-03-01 08:07:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 08:11:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 08:11:36]

Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Ramin Halavati, 2017-03-01 08:42:29]

On 2017/03/01 08:11:36, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_cronet on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

I am sorry Asanka, I didn't notice you hadn't approved deps yet.

[Ramin Halavati, 2017-03-01 08:49:12]

On 2017/03/01 08:42:29, Ramin Halavati wrote:
> On 2017/03/01 08:11:36, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   android_cronet on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
> 
> I am sorry Asanka, I didn't notice you hadn't approved deps yet.

asanka@:
Also could you please suggest what is the correct approach to set DEPS here?
I used "+net/test_support" and received the following presubmit error:
Illegal include:
"net/traffic_annotation/network_traffic_annotation_test_helper.h"
    Because of no rule applying.

[asanka, 2017-03-02 03:11:41]

On 2017/03/01 08:49:12, Ramin Halavati wrote:
> On 2017/03/01 08:42:29, Ramin Halavati wrote:
> > On 2017/03/01 08:11:36, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   android_cronet on master.tryserver.chromium.android (JOB_FAILED,
> > >
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
> > 
> > I am sorry Asanka, I didn't notice you hadn't approved deps yet.
> 
> asanka@:
> Also could you please suggest what is the correct approach to set DEPS here?
> I used "+net/test_support" and received the following presubmit error:
> Illegal include:
> "net/traffic_annotation/network_traffic_annotation_test_helper.h"
>     Because of no rule applying.

The DEPS change is fine. But BUILD.gn in //device needs to explicitly add a
dependency on //net:test_support.

[Ramin Halavati, 2017-03-02 06:02:16]

Thank you asanka@

reillyg@:
Please review BUILD.gn change.

[Reilly Grant (use Gerrit), 2017-03-02 19:36:10]

lgtm

[Ramin Halavati, 2017-03-03 06:34:43]

The CQ bit was checked by rhalavati@chromium.org

[commit-bot: I haz the power, 2017-03-03 06:34:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 06:41:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 06:41:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ramin Halavati, 2017-03-03 06:46:17]

asanka@:
Comments addressed, please review DEPS as owner of net/.

[asanka, 2017-03-03 14:36:38]

LGTM

[Ramin Halavati, 2017-03-03 14:37:13]

The CQ bit was checked by rhalavati@chromium.org

[commit-bot: I haz the power, 2017-03-03 14:37:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 15:08:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488551833659340,
"parent_rev": "321806ab7acbd5756ed30659d0b916a7af54f13a", "commit_rev":
"d75e16c38dd0918d0f38307aacd51241ee56f318"}

[commit-bot: I haz the power, 2017-03-03 15:09:03]

Description was changed from

==========
Network traffic annotation added to usb_test_gadget_impl.

Network traffic annotation is added to network request of
usb_test_gadget_impl.

BUG=656607
==========

to

==========
Network traffic annotation added to usb_test_gadget_impl.

Network traffic annotation is added to network request of
usb_test_gadget_impl.

BUG=656607

Review-Url: https://codereview.chromium.org/2719123003
Cr-Commit-Position: refs/heads/master@{#454583}
Committed:
https://chromium.googlesource.com/chromium/src/+/d75e16c38dd0918d0f38307aacd5...
==========

[commit-bot: I haz the power, 2017-03-03 15:09:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d75e16c38dd0918d0f38307aacd5...