Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2719093002: Note Options deprecation in more places (Closed)

Created:
3 years, 9 months ago by michaelpg
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Note Options deprecation in more places Trying to prevent folks from creating large CLs in Options only to discover we intend to deprecate it shortly. This codifies a few assumptions we've been making about where new code should go. BUG=none R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2719093002 Cr-Commit-Position: refs/heads/master@{#453304} Committed: https://chromium.googlesource.com/chromium/src/+/8f65e273d2658c78478fe273b9a1e84503cbc867

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M chrome/browser/resources/options/chromeos/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M docs/chrome_settings.md View 1 1 chunk +21 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
michaelpg
PTAL.
3 years, 9 months ago (2017-02-27 18:14:54 UTC) #2
Dan Beam
https://codereview.chromium.org/2719093002/diff/1/docs/chrome_settings.md File docs/chrome_settings.md (right): https://codereview.chromium.org/2719093002/diff/1/docs/chrome_settings.md#newcode12 docs/chrome_settings.md:12: those new features in MD Settings. can you just ...
3 years, 9 months ago (2017-02-27 18:48:15 UTC) #3
michaelpg
https://codereview.chromium.org/2719093002/diff/1/docs/chrome_settings.md File docs/chrome_settings.md (right): https://codereview.chromium.org/2719093002/diff/1/docs/chrome_settings.md#newcode12 docs/chrome_settings.md:12: those new features in MD Settings. On 2017/02/27 18:48:15, ...
3 years, 9 months ago (2017-02-27 18:58:29 UTC) #4
Dan Beam
lgtm and thanks for the updates!
3 years, 9 months ago (2017-02-27 19:10:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719093002/20001
3 years, 9 months ago (2017-02-27 19:31:41 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 19:52:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8f65e273d2658c78478fe273b9a1...

Powered by Google App Engine
This is Rietveld 408576698