Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Issue 2719073002: Revert of DirectCompositorFrameSink Uses CompositorFrameSinkSupport (Closed)

Created:
3 years, 9 months ago by Alex Z.
Modified:
3 years, 9 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DirectCompositorFrameSink Uses CompositorFrameSinkSupport (patchset #40 id:870001 of https://codereview.chromium.org/2612083002/ ) Reason for revert: This CL broke several perf tests on Windows. (https://bugs.chromium.org/p/chromium/issues/detail?id=696030) Original issue's description: > DirectCompositorFrameSink Uses CompositorFrameSinkSupport > > CompositorFrameSinkSupport is the common service-side implementation of > CompositorFrameSink. In an effort to evaluate mojo performance > independently of refactoring existing code, CompositorFrameSinkSupport > provides the same public interface as MojoCompositorFrameSink but does > not depend on mojo. > > This CL takes us in the direction of splitting DirectCompositorFrameSink > into two pieces: a client side component and a service side component. > > BUG=673543 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2612083002 > Cr-Original-Commit-Position: refs/heads/master@{#448731} > Committed: https://chromium.googlesource.com/chromium/src/+/c405416053b99aa4d6f98f3126608c660773f6b4 > Review-Url: https://codereview.chromium.org/2612083002 > Cr-Commit-Position: refs/heads/master@{#451462} > Committed: https://chromium.googlesource.com/chromium/src/+/9d4e3df6e621c6bd80dfaee7008b3e33d0c4fe79 TBR=reveman@chromium.org,danakj@chromium.org,fsamuel@chromium.org,jbauman@chromium.org,xlai@chromium.org,boliu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=673543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -59 lines) Patch
M cc/surfaces/compositor_frame_sink_support.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/surfaces/compositor_frame_sink_support.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.h View 5 chunks +7 lines, -16 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.cc View 6 chunks +28 lines, -38 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Alex Z.
Created Revert of DirectCompositorFrameSink Uses CompositorFrameSinkSupport
3 years, 9 months ago (2017-02-27 16:22:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719073002/1
3 years, 9 months ago (2017-02-27 16:23:06 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-02-27 16:23:08 UTC) #5
Alex Z.
Please lgtm this CL so that the tests can stop breaking.
3 years, 9 months ago (2017-02-27 16:28:34 UTC) #6
boliu
rs lgtm
3 years, 9 months ago (2017-02-27 16:30:14 UTC) #7
Fady Samuel
On 2017/02/27 16:30:14, boliu wrote: > rs lgtm Wait, I'd like to understand what regressed ...
3 years, 9 months ago (2017-02-27 16:34:08 UTC) #8
Fady Samuel
3 years, 9 months ago (2017-02-27 16:34:09 UTC) #9
On 2017/02/27 16:30:14, boliu wrote:
> rs lgtm

Wait, I'd like to understand what regressed first.

Powered by Google App Engine
This is Rietveld 408576698