Provide Copy button for username in password settings

ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/settings/password_details_collection_view_controller.h"
 
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/autofill/core/common/password_form.h"
 #import "ios/chrome/browser/ui/collection_view/collection_view_controller_test.h"
@@ skipping 50 matching lines @@
 - (void)deletePassword:(const autofill::PasswordForm&)passwordForm {
   ++_numberOfCallsToDeletePassword;
 }
 
 @end
 
 namespace {
 
 NSString* kUsername = @"testusername";
 NSString* kPassword = @"testpassword";
-int kShowHideButtonItem = 1;
-int kCopyButtonItem = 2;
-int kDeleteButtonItem = 3;
+
 int kUsernameSection = 0;
 int kUsernameItem = 0;
+int kCopyUsernameButtonItem = 1;

[vabr (Chromium), 2017/05/01 18:49:53]

I just noticed that this all should be const, given the naming.
I fixed that in the follow-up CL https://codereview.chromium.org/2722853003/, so
would suggest to leave it here as is already.

+
 int kPasswordSection = 1;
 int kPasswordItem = 0;
+int kShowHideButtonItem = 1;
+int kCopyPasswordButtonItem = 2;
+int kDeleteButtonItem = 3;
 
 class PasswordDetailsCollectionViewControllerTest
     : public CollectionViewControllerTest {
  protected:
   PasswordDetailsCollectionViewControllerTest()
       : thread_bundle_(web::TestWebThreadBundle::REAL_DB_THREAD) {}
   void SetUp() override {
     CollectionViewControllerTest::SetUp();
     origin_ = @"testorigin.com";
     delegate_ = [[MockSavePasswordsCollectionViewController alloc] init];
@@ skipping 19 matching lines @@
   MockSavePasswordsCollectionViewController* delegate_;
   MockReauthenticationModule* reauthenticationModule_;
   NSString* origin_;
 };
 
 TEST_F(PasswordDetailsCollectionViewControllerTest, TestInitialization) {
   CreateController();
   CheckController();
   EXPECT_EQ(2, NumberOfSections());
   // Username section
-  EXPECT_EQ(1, NumberOfItemsInSection(kUsernameSection));
+  EXPECT_EQ(2, NumberOfItemsInSection(kUsernameSection));
   CheckSectionHeaderWithId(IDS_IOS_SHOW_PASSWORD_VIEW_USERNAME,
                            kUsernameSection);
   PasswordDetailsItem* usernameItem =
       GetCollectionViewItem(kUsernameSection, kUsernameItem);
   EXPECT_NSEQ(kUsername, usernameItem.text);
   EXPECT_TRUE(usernameItem.showingText);
+  CheckTextCellTitleWithId(IDS_IOS_SETTINGS_USERNAME_COPY_BUTTON,
+                           kUsernameSection, kCopyUsernameButtonItem);
   // Password section
   EXPECT_EQ(4, NumberOfItemsInSection(kPasswordSection));
   CheckSectionHeaderWithId(IDS_IOS_SHOW_PASSWORD_VIEW_PASSWORD,
                            kPasswordSection);
   PasswordDetailsItem* passwordItem =
       GetCollectionViewItem(kPasswordSection, kPasswordItem);
   EXPECT_NSEQ(kPassword, passwordItem.text);
   EXPECT_FALSE(passwordItem.showingText);
   CheckTextCellTitleWithId(IDS_IOS_SETTINGS_PASSWORD_SHOW_BUTTON,
                            kPasswordSection, kShowHideButtonItem);
   CheckTextCellTitleWithId(IDS_IOS_SETTINGS_PASSWORD_COPY_BUTTON,
-                           kPasswordSection, kCopyButtonItem);
+                           kPasswordSection, kCopyPasswordButtonItem);
   CheckTextCellTitleWithId(IDS_IOS_SETTINGS_PASSWORD_DELETE_BUTTON,
                            kPasswordSection, kDeleteButtonItem);
 }
 
 struct SimplifyOriginTestData {
   NSString* origin;
   NSString* expectedSimplifiedOrigin;
 };
 
 TEST_F(PasswordDetailsCollectionViewControllerTest, SimplifyOrigin) {
   SimplifyOriginTestData test_data[] = {
       {@"http://test.com/index.php", @"test.com"},
       {@"test.com/index.php", @"test.com"},
       {@"test.com", @"test.com"}};
 
   for (size_t i = 0; i < arraysize(test_data); i++) {
     SimplifyOriginTestData& data = test_data[i];
     CreateControllerWithOrigin(data.origin);
     EXPECT_NSEQ(data.expectedSimplifiedOrigin, controller().title)
         << " for origin " << base::SysNSStringToUTF8(test_data[i].origin);
     ResetController();
   }
 }
 
+TEST_F(PasswordDetailsCollectionViewControllerTest, CopyUsername) {
+  CreateController();
+  [controller() collectionView:[controller() collectionView]
+      didSelectItemAtIndexPath:[NSIndexPath
+                                   indexPathForRow:kCopyUsernameButtonItem
+                                         inSection:kUsernameSection]];
+  UIPasteboard* generalPasteboard = [UIPasteboard generalPasteboard];
+  EXPECT_NSEQ(kUsername, generalPasteboard.string);
+}
+
 TEST_F(PasswordDetailsCollectionViewControllerTest, ShowPassword) {
   CreateController();
   [controller() collectionView:[controller() collectionView]
       didSelectItemAtIndexPath:[NSIndexPath indexPathForRow:kShowHideButtonItem
                                                   inSection:kPasswordSection]];
   PasswordDetailsItem* passwordItem =
       GetCollectionViewItem(kPasswordSection, kPasswordItem);
   EXPECT_NSEQ(kPassword, passwordItem.text);
   EXPECT_TRUE(passwordItem.showingText);
   EXPECT_NSEQ(
@@ skipping 17 matching lines @@
       GetCollectionViewItem(kPasswordSection, kPasswordItem);
   EXPECT_NSEQ(kPassword, passwordItem.text);
   EXPECT_FALSE(passwordItem.showingText);
   CheckTextCellTitleWithId(IDS_IOS_SETTINGS_PASSWORD_SHOW_BUTTON,
                            kPasswordSection, kShowHideButtonItem);
 }
 
 TEST_F(PasswordDetailsCollectionViewControllerTest, CopyPassword) {
   CreateController();
   [controller() collectionView:[controller() collectionView]
-      didSelectItemAtIndexPath:[NSIndexPath indexPathForRow:kCopyButtonItem
-                                                  inSection:kPasswordSection]];
+      didSelectItemAtIndexPath:[NSIndexPath
+                                   indexPathForRow:kCopyPasswordButtonItem
+                                         inSection:kPasswordSection]];
   UIPasteboard* generalPasteboard = [UIPasteboard generalPasteboard];
   EXPECT_NSEQ(kPassword, generalPasteboard.string);
   EXPECT_NSEQ(
       l10n_util::GetNSString(IDS_IOS_SETTINGS_PASSWORD_REAUTH_REASON_COPY),
       reauthenticationModule_.localizedReasonForAuthentication);
 }
 
 TEST_F(PasswordDetailsCollectionViewControllerTest, DeletePassword) {
   CreateController();
   [controller() collectionView:[controller() collectionView]
       didSelectItemAtIndexPath:[NSIndexPath indexPathForRow:kDeleteButtonItem
                                                   inSection:kPasswordSection]];
   EXPECT_EQ(1, delegate_.numberOfCallsToDeletePassword);
 }
 
 }  // namespace