Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2719023002: [turbofan] Inline Array.isArray in JSBuiltinReducer. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Inline Array.isArray in JSBuiltinReducer. Inline the Array.isArray builtin during typed lowering, which generates ideal code for the common case (non-JSProxy arg), and use the existing %ArrayIsArray runtime function for the JSProxy case just like in baseline. BUG=v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2719023002 Cr-Commit-Position: refs/heads/master@{#43453} Committed: https://chromium.googlesource.com/v8/v8/+/c45da1b47b39a93f12258b2ac427ff83de4f942f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +100 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 9 months ago (2017-02-27 12:55:38 UTC) #1
Benedikt Meurer
Hey Jaro, Spotted this one in React / Angular. Pretty simple optimization. Please take a ...
3 years, 9 months ago (2017-02-27 13:08:10 UTC) #4
Jarin
lgtm
3 years, 9 months ago (2017-02-27 13:28:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719023002/1
3 years, 9 months ago (2017-02-27 13:29:04 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 14:11:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c45da1b47b39a93f12258b2ac427ff83de4...

Powered by Google App Engine
This is Rietveld 408576698