Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2719013003: Remove a redundant layout update from DragCaret.cpp (Closed)

Created:
3 years, 9 months ago by Xiaocheng
Modified:
3 years, 9 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a redundant layout update from DragCaret.cpp The call site of updateStyleAndLayout in DragCaret::setCaretPosition was originally serving a computeCaretRect call, which has been removed in crrev.com/448799. This patch hence removes the redundant layout update call. BUG=590369 TEST=n/a; no behavior change Review-Url: https://codereview.chromium.org/2719013003 Cr-Commit-Position: refs/heads/master@{#453525} Committed: https://chromium.googlesource.com/chromium/src/+/10ef6d7aef78f2cee1d08f7cf4ba6b1ffe772948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/DragCaret.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
3 years, 9 months ago (2017-02-28 00:12:15 UTC) #5
yosin_UTC9
lgtm Good catch!
3 years, 9 months ago (2017-02-28 01:37:02 UTC) #6
Xiaocheng
Thanks for review!
3 years, 9 months ago (2017-02-28 01:49:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719013003/1
3 years, 9 months ago (2017-02-28 01:49:51 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 06:31:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10ef6d7aef78f2cee1d08f7cf4ba...

Powered by Google App Engine
This is Rietveld 408576698