Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 27190: Makes it so windows opened from links in Windows Live Messenger cause the win... (Closed)

11 years, 10 months ago by Ben Goodger (Google)
9 years, 6 months ago
Base URL:


Makes it so windows opened from links in Windows Live Messenger cause the window to appear instead of being invisible. The discovery is that Windows enforces that you call ShowWindow with the value of STARTUPINFO's wShowWindow field first before calling it with any other value, otherwise all subsequent calls are ignored. I used to have code that flattened the return value of a function into something that would ensure the window is visible, but what I actually needed to do was show the window twice in this case. Ick. TEST=Have someone send you a link in a Windows Live Messenger window, click it without Chrome running (Chrome must be default browser), and a Chrome window should appear, visible, loading the link. Also try running chrome.exe from bash to make sure that still works. Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/views/frame/ View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/views/ View 2 chunks +8 lines, -1 line 0 comments Download


Total messages: 2 (0 generated)
Ben Goodger (Google)
11 years, 10 months ago (2009-02-26 01:41:18 UTC) #1
Nicolas Sylvain
11 years, 10 months ago (2009-02-26 03:05:20 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698