Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 27190: Makes it so windows opened from links in Windows Live Messenger cause the win... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by Ben Goodger (Google)
Modified:
5 years, 11 months ago
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Makes it so windows opened from links in Windows Live Messenger cause the window to appear instead of being invisible. The discovery is that Windows enforces that you call ShowWindow with the value of STARTUPINFO's wShowWindow field first before calling it with any other value, otherwise all subsequent calls are ignored. I used to have code that flattened the return value of a function into something that would ensure the window is visible, but what I actually needed to do was show the window twice in this case. Ick. http://crbug.com/3126 TEST=Have someone send you a link in a Windows Live Messenger window, click it without Chrome running (Chrome must be default browser), and a Chrome window should appear, visible, loading the link. Also try running chrome.exe from bash to make sure that still works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/views/frame/browser_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/views/window.cc View 2 chunks +8 lines, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
8 years, 2 months ago (2009-02-26 01:41:18 UTC) #1
Nicolas Sylvain
8 years, 2 months ago (2009-02-26 03:05:20 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06