Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2718943003: mv FetchTestingPlatformSupport to platform/loader/testing (Closed)

Created:
3 years, 9 months ago by kouhei (in TOK)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mv FetchTestingPlatformSupport to platform/loader/testing This CL moves FetchTestingPlatformSupport to platform/loader/testing dir and under test_support build target. This CL prepares its usage in ModuleMapTest to be introduced in: https://codereview.chromium.org/2704323002/ BUG=594639 Review-Url: https://codereview.chromium.org/2718943003 Cr-Commit-Position: refs/heads/master@{#453518} Committed: https://chromium.googlesource.com/chromium/src/+/da62656d9b7a2f572f7c9d0fc634182a0903e136

Patch Set 1 #

Total comments: 2

Patch Set 2 : move also mockfetchcontext #

Patch Set 3 : Revert uninteded RFTest change #

Total comments: 1

Patch Set 4 : toyoshim #

Patch Set 5 : ResourceFetcherTest fix #

Total comments: 1

Patch Set 6 : MCTest fix #

Patch Set 7 : MCTest fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -190 lines) Patch
M third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/platform/loader/fetch/FetchTestingPlatformSupport.h View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/platform/loader/fetch/FetchTestingPlatformSupport.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/loader/fetch/MockFetchContext.h View 1 1 chunk +0 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/testing/FetchTestingPlatformSupport.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/loader/testing/FetchTestingPlatformSupport.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 43 (25 generated)
kouhei (in TOK)
3 years, 9 months ago (2017-02-27 02:28:43 UTC) #2
haraken
LGTM
3 years, 9 months ago (2017-02-27 02:40:17 UTC) #5
kinuko
https://codereview.chromium.org/2718943003/diff/1/third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp File third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp (right): https://codereview.chromium.org/2718943003/diff/1/third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp#newcode8 third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp:8: #include "platform/loader/fetch/MockFetchContext.h" This Platform class has a public getter ...
3 years, 9 months ago (2017-02-27 02:41:08 UTC) #7
kouhei (in TOK)
https://codereview.chromium.org/2718943003/diff/1/third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp File third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp (right): https://codereview.chromium.org/2718943003/diff/1/third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp#newcode8 third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp:8: #include "platform/loader/fetch/MockFetchContext.h" On 2017/02/27 02:41:08, kinuko wrote: > This ...
3 years, 9 months ago (2017-02-27 03:31:37 UTC) #8
kinuko
lgtm
3 years, 9 months ago (2017-02-27 04:21:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718943003/40001
3 years, 9 months ago (2017-02-27 04:47:15 UTC) #16
Takashi Toyoshima
https://codereview.chromium.org/2718943003/diff/40001/third_party/WebKit/Source/platform/BUILD.gn File third_party/WebKit/Source/platform/BUILD.gn (right): https://codereview.chromium.org/2718943003/diff/40001/third_party/WebKit/Source/platform/BUILD.gn#newcode1578 third_party/WebKit/Source/platform/BUILD.gn:1578: "testing/FetchTestingPlatformSupport.cpp", directory moving is not necessary to use them ...
3 years, 9 months ago (2017-02-27 06:01:31 UTC) #17
kouhei (in TOK)
On 2017/02/27 06:01:31, Takashi Toyoshima wrote: > https://codereview.chromium.org/2718943003/diff/40001/third_party/WebKit/Source/platform/BUILD.gn > File third_party/WebKit/Source/platform/BUILD.gn (right): > > https://codereview.chromium.org/2718943003/diff/40001/third_party/WebKit/Source/platform/BUILD.gn#newcode1578 ...
3 years, 9 months ago (2017-02-27 06:27:39 UTC) #21
Takashi Toyoshima
lgtm
3 years, 9 months ago (2017-02-27 06:48:19 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718943003/60001
3 years, 9 months ago (2017-02-27 06:49:11 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/398139)
3 years, 9 months ago (2017-02-27 07:06:43 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718943003/80001
3 years, 9 months ago (2017-02-27 07:10:03 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/318617)
3 years, 9 months ago (2017-02-27 07:28:14 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718943003/80001
3 years, 9 months ago (2017-02-27 07:33:52 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/372786)
3 years, 9 months ago (2017-02-27 07:38:28 UTC) #36
Takashi Toyoshima
CQ failure looks a real error. https://codereview.chromium.org/2718943003/diff/80001/third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp File third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp (right): https://codereview.chromium.org/2718943003/diff/80001/third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp#newcode40 third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp:40: #include "platform/loader/testing/TestingPlatformSupport.h" TestingPlatformSupport ...
3 years, 9 months ago (2017-02-27 13:03:07 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718943003/120001
3 years, 9 months ago (2017-02-28 01:48:48 UTC) #40
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 06:16:11 UTC) #43
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/da62656d9b7a2f572f7c9d0fc634...

Powered by Google App Engine
This is Rietveld 408576698