mv FetchTestingPlatformSupport to platform/loader/testing

mv FetchTestingPlatformSupport to platform/loader/testing

This CL moves FetchTestingPlatformSupport to platform/loader/testing dir and under test_support build target.
This CL prepares its usage in ModuleMapTest to be introduced in:
https://codereview.chromium.org/2704323002/

BUG=594639
Review-Url: https://codereview.chromium.org/2718943003
Cr-Commit-Position: refs/heads/master@{#453518}
Committed: https://chromium.googlesource.com/chromium/src/+/da62656d9b7a2f572f7c9d0fc634182a0903e136

[kouhei (in TOK), 2017-02-27 02:28:42]

kouhei@chromium.org changed reviewers:
+ haraken@chromium.org, toyoshim@chromium.org

[kouhei (in TOK), 2017-02-27 02:28:49]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 02:28:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-27 02:40:17]

LGTM

[kinuko, 2017-02-27 02:41:07]

kinuko@chromium.org changed reviewers:
+ kinuko@chromium.org

[kinuko, 2017-02-27 02:41:08]

https://codereview.chromium.org/2718943003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp
(right):

https://codereview.chromium.org/2718943003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp:8:
#include "platform/loader/fetch/MockFetchContext.h"
This Platform class has a public getter for MockFetchContext, only moving this
one feels a bit weird?

[kouhei (in TOK), 2017-02-27 03:31:37]

https://codereview.chromium.org/2718943003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp
(right):

https://codereview.chromium.org/2718943003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/testing/FetchTestingPlatformSupport.cpp:8:
#include "platform/loader/fetch/MockFetchContext.h"
On 2017/02/27 02:41:08, kinuko wrote:
> This Platform class has a public getter for MockFetchContext, only moving this
> one feels a bit weird?

Done.

[kouhei (in TOK), 2017-02-27 03:31:41]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 03:31:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-02-27 04:21:45]

lgtm

[commit-bot: I haz the power, 2017-02-27 04:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 04:43:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kouhei (in TOK), 2017-02-27 04:46:55]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-02-27 04:46:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2718943003/#ps40001
(title: "Revert uninteded RFTest change")

[commit-bot: I haz the power, 2017-02-27 04:47:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-02-27 06:01:31]

https://codereview.chromium.org/2718943003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2718943003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/BUILD.gn:1578:
"testing/FetchTestingPlatformSupport.cpp",
directory moving is not necessary to use them from core.
Files in "blink_platform_unittests" are not visible from webkit_unit_tests, but
files in "test_support" can.

I hesitate to moving these to testing, a little. because of a concern about
commons tragedy that easily happens in testing like directory.

I prefer to having loader/testing, and move these files and loader/fetch/Mock*
into there.

[kouhei (google), 2017-02-27 06:02:03]

The CQ bit was unchecked by kouhei@google.com

[kouhei (in TOK), 2017-02-27 06:26:55]

Description was changed from

==========
mv FetchTestingPlatformSupport to platform/testing

This CL moves FetchTestingPlatformSupport to platform/testing, so that
it could be used from core/dom unit_tests.
This CL prepares its usage in ModuleMapTest to be introduced in:
https://codereview.chromium.org/2704323002/

BUG=594639
==========

to

==========
mv FetchTestingPlatformSupport to platform/testing

This CL moves FetchTestingPlatformSupport to platform/loader/testing dir and
under test_support build target.
This CL prepares its usage in ModuleMapTest to be introduced in:
https://codereview.chromium.org/2704323002/

BUG=594639
==========

[kouhei (in TOK), 2017-02-27 06:27:11]

Description was changed from

==========
mv FetchTestingPlatformSupport to platform/testing

This CL moves FetchTestingPlatformSupport to platform/loader/testing dir and
under test_support build target.
This CL prepares its usage in ModuleMapTest to be introduced in:
https://codereview.chromium.org/2704323002/

BUG=594639
==========

to

==========
mv FetchTestingPlatformSupport to platform/loader/testing

This CL moves FetchTestingPlatformSupport to platform/loader/testing dir and
under test_support build target.
This CL prepares its usage in ModuleMapTest to be introduced in:
https://codereview.chromium.org/2704323002/

BUG=594639
==========

[kouhei (in TOK), 2017-02-27 06:27:39]

On 2017/02/27 06:01:31, Takashi Toyoshima wrote:
>
https://codereview.chromium.org/2718943003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2718943003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/BUILD.gn:1578:
> "testing/FetchTestingPlatformSupport.cpp",
> directory moving is not necessary to use them from core.
> Files in "blink_platform_unittests" are not visible from webkit_unit_tests,
but
> files in "test_support" can.
> 
> I hesitate to moving these to testing, a little. because of a concern about
> commons tragedy that easily happens in testing like directory.
> 
> I prefer to having loader/testing, and move these files and loader/fetch/Mock*
> into there.

Done.

[Takashi Toyoshima, 2017-02-27 06:48:19]

lgtm

[kouhei (in TOK), 2017-02-27 06:48:48]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-02-27 06:48:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2718943003/#ps60001
(title: "toyoshim")

[commit-bot: I haz the power, 2017-02-27 06:49:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 07:06:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 07:06:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kouhei (in TOK), 2017-02-27 07:09:45]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-02-27 07:09:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, toyoshim@chromium.org, kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2718943003/#ps80001
(title: "ResourceFetcherTest fix")

[commit-bot: I haz the power, 2017-02-27 07:10:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 07:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 07:28:14]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Takashi Toyoshima, 2017-02-27 07:33:42]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2017-02-27 07:33:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 07:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 07:38:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Takashi Toyoshima, 2017-02-27 13:03:07]

CQ failure looks a real error.

https://codereview.chromium.org/2718943003/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp
(right):

https://codereview.chromium.org/2718943003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp:40:
#include "platform/loader/testing/TestingPlatformSupport.h"
TestingPlatformSupport should be still in platform/testing.

../../third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp:40:10:
fatal error: 'platform/loader/testing/TestingPlatformSupport.h' file not found
#include "platform/loader/testing/TestingPlatformSupport.h"

[kouhei (in TOK), 2017-02-28 01:47:52]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-02-28 01:47:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, toyoshim@chromium.org, kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2718943003/#ps120001
(title: "MCTest fix")

[commit-bot: I haz the power, 2017-02-28 01:48:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 06:14:29]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1488246472705500,
"parent_rev": "fc9533e11917bced54ea40a842d9b0333bc85b09", "commit_rev":
"da62656d9b7a2f572f7c9d0fc634182a0903e136"}

[commit-bot: I haz the power, 2017-02-28 06:16:09]

Description was changed from

==========
mv FetchTestingPlatformSupport to platform/loader/testing

This CL moves FetchTestingPlatformSupport to platform/loader/testing dir and
under test_support build target.
This CL prepares its usage in ModuleMapTest to be introduced in:
https://codereview.chromium.org/2704323002/

BUG=594639
==========

to

==========
mv FetchTestingPlatformSupport to platform/loader/testing

This CL moves FetchTestingPlatformSupport to platform/loader/testing dir and
under test_support build target.
This CL prepares its usage in ModuleMapTest to be introduced in:
https://codereview.chromium.org/2704323002/

BUG=594639

Review-Url: https://codereview.chromium.org/2718943003
Cr-Commit-Position: refs/heads/master@{#453518}
Committed:
https://chromium.googlesource.com/chromium/src/+/da62656d9b7a2f572f7c9d0fc634...
==========

[commit-bot: I haz the power, 2017-02-28 06:16:11]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/da62656d9b7a2f572f7c9d0fc634...