Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2718903002: android: Rename SwapBuffers to SwapFrames (Closed)

Created:
3 years, 9 months ago by boliu
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-vr-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Rename SwapBuffers to SwapFrames The name is misleading now that Display and browser compositor are separate. The callback only corresponds to SwapBuffers where there was a new frame from the browser compositor. This is in anticipation of adding the a callback that actually corresponds to all swap buffers regardless of cause. BUG=512636 Review-Url: https://codereview.chromium.org/2718903002 Cr-Commit-Position: refs/heads/master@{#453489} Committed: https://chromium.googlesource.com/chromium/src/+/ba835900ea6c74f762e37d10354d4c6a1b67edc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -37 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutRenderHost.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/MockLayoutHost.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/compositor/compositor_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/compositor/compositor_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_compositor.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_compositor.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/android/content_view_render_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_render_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/android/compositor_client.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
boliu
ptal mthiesse@chromium.org: Please review changes in chrome vr changwan@chromium.org: Please review changes in chrome compositor ...
3 years, 9 months ago (2017-02-27 16:33:27 UTC) #3
mthiesse
vr_shell/ lgtm
3 years, 9 months ago (2017-02-27 16:40:57 UTC) #4
aelias_OOO_until_Jul13
lgtm
3 years, 9 months ago (2017-02-28 00:15:42 UTC) #5
Changwan Ryu
*/compositor/* lgtm
3 years, 9 months ago (2017-02-28 02:47:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718903002/1
3 years, 9 months ago (2017-02-28 02:50:18 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 04:11:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba835900ea6c74f762e37d10354d...

Powered by Google App Engine
This is Rietveld 408576698