Measure CanvasRenderingContext2D.getContextAttributes() usage

Measure CanvasRenderingContext2D.getContextAttributes() usage

To make sure that we can put the unintentionally exposed
CanvasRenderingContext2D.getContextAttributes() behind a flag
without breaking websites out there, we need to measure its usage.

BUG=696005
Review-Url: https://codereview.chromium.org/2718783002
Cr-Commit-Position: refs/heads/master@{#455163}
Committed: https://chromium.googlesource.com/chromium/src/+/b1d2e017aef891e5d9bbd4d58b22fe9b08c46db3

[zakerinasab, 2017-02-24 21:44:13]

Description was changed from

==========
Put CanvasRenderingContext2D.getContextAttributes() behind flag

Put CanvasRenderingContext2D.getContextAttributes() behind
EnableExperimentalCanvasFeatures flag.

BUG=696005
==========

to

==========
Put CanvasRenderingContext2D.getContextAttributes() behind flag

Put CanvasRenderingContext2D.getContextAttributes() behind
EnableExperimentalCanvasFeatures flag.

BUG=696005
==========

[zakerinasab, 2017-02-24 21:44:13]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[zakerinasab, 2017-02-24 21:44:27]

CL uploaded. PTAL.

[Justin Novosad, 2017-02-24 22:02:14]

junov@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Justin Novosad, 2017-02-24 22:02:15]

not lgtm.

I tracked this down to a CL from 2013:
https://chromium.googlesource.com/chromium/src/+/d1551f0663ddb783db3d309d7914...

Event though this API was not publicized and is not in any other browser, it has
been around for long enough that there is a non-negligible risk that removing it
could break something on the web.  Start by putting a [MeasureAs=] on it so we
can ascertain whether this API has been discovered by anyone.  If the count is
zero, we can probably just un-ship it. Otherwise, it's trickier.

[zakerinasab, 2017-02-27 15:26:05]

zakerinasab@chromium.org changed reviewers:
+ haraken@chromium.org
- chrishtr@chromium.org

[zakerinasab, 2017-02-27 15:31:16]

Comments addressed. PTAL.

[Justin Novosad, 2017-02-27 16:11:43]

junov@chromium.org changed reviewers:
+ jwd@chromium.org
- haraken@chromium.org

[Justin Novosad, 2017-02-27 16:11:43]

lgtm
+jwd for histograms

[Justin Novosad, 2017-02-27 16:12:24]

Please rename the CL and modify the description to reflect what the CL actually
does.

[zakerinasab, 2017-02-27 17:04:36]

Description was changed from

==========
Put CanvasRenderingContext2D.getContextAttributes() behind flag

Put CanvasRenderingContext2D.getContextAttributes() behind
EnableExperimentalCanvasFeatures flag.

BUG=696005
==========

to

==========
Measure CanvasRenderingContext2D.getContextAttributes() usage

To make sure that we can put the unintentionally exposed
CanvasRenderingContext2D.getContextAttributes() behind a flag
without breaking websites out there, we need to measure its usage.

BUG=696005
==========

[jwd, 2017-03-01 20:05:58]

histograms lgtm

[zakerinasab, 2017-03-02 14:50:42]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-03-02 14:50:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 14:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 14:53:25]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[zakerinasab, 2017-03-06 15:25:56]

The CQ bit was checked by zakerinasab@chromium.org

[zakerinasab, 2017-03-06 15:25:57]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org,
junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2718783002/#ps60001
(title: "Rebaseline")

[commit-bot: I haz the power, 2017-03-06 15:26:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 17:21:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 17:21:25]

Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/frame/UseCounter.h:1476
  error: third_party/WebKit/Source/core/frame/UseCounter.h: patch does not apply

Patch:       third_party/WebKit/Source/core/frame/UseCounter.h
Index: third_party/WebKit/Source/core/frame/UseCounter.h
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h
b/third_party/WebKit/Source/core/frame/UseCounter.h
index
d00df541ccee139e183207df8d4acfa0457ee422..a0e2148de98484683f6abf6a3b99ec0e5d661418
100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.h
+++ b/third_party/WebKit/Source/core/frame/UseCounter.h
@@ -1476,6 +1476,7 @@ class CORE_EXPORT UseCounter {
     ScrollByKeyboardSpacebarKey = 1846,
     ScrollByTouch = 1847,
     ScrollByWheel = 1848,
+    GetCanvas2DContextAttributes = 1849,
 
     // Add new features immediately above this line. Don't change assigned
     // numbers of any item, and don't reuse removed slots.

[zakerinasab, 2017-03-07 01:10:00]

The CQ bit was checked by zakerinasab@chromium.org

[zakerinasab, 2017-03-07 01:10:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org,
junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2718783002/#ps80001
(title: "Rebaseline")

[commit-bot: I haz the power, 2017-03-07 01:11:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 03:05:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 03:05:04]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[zakerinasab, 2017-03-07 14:39:09]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-03-07 14:39:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 17:19:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 17:19:02]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[zakerinasab, 2017-03-07 17:20:37]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-03-07 17:21:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 18:57:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488907237292430,
"parent_rev": "2f70e7b8392fb596d17ec625bc07727b2a663e4e", "commit_rev":
"b1d2e017aef891e5d9bbd4d58b22fe9b08c46db3"}

[commit-bot: I haz the power, 2017-03-07 18:57:44]

Description was changed from

==========
Measure CanvasRenderingContext2D.getContextAttributes() usage

To make sure that we can put the unintentionally exposed
CanvasRenderingContext2D.getContextAttributes() behind a flag
without breaking websites out there, we need to measure its usage.

BUG=696005
==========

to

==========
Measure CanvasRenderingContext2D.getContextAttributes() usage

To make sure that we can put the unintentionally exposed
CanvasRenderingContext2D.getContextAttributes() behind a flag
without breaking websites out there, we need to measure its usage.

BUG=696005

Review-Url: https://codereview.chromium.org/2718783002
Cr-Commit-Position: refs/heads/master@{#455163}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1d2e017aef891e5d9bbd4d58b22...
==========

[commit-bot: I haz the power, 2017-03-07 18:57:46]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b1d2e017aef891e5d9bbd4d58b22...