Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2130)

Unified Diff: ash/shelf/shelf_view_unittest.cc

Issue 2718763003: chromeos: makes more tests run in both mash and ash (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_view_unittest.cc
diff --git a/ash/shelf/shelf_view_unittest.cc b/ash/shelf/shelf_view_unittest.cc
index d3a1b3d3a4c6ef74c2a2af6d0f604e8557a37832..218741f68c29dd94966d01439551f15d0adf5a52 100644
--- a/ash/shelf/shelf_view_unittest.cc
+++ b/ash/shelf/shelf_view_unittest.cc
@@ -197,6 +197,10 @@ TEST_F(WmShelfObserverIconTest, AddRemove) {
// Make sure creating/deleting an window on one displays notifies a
// shelf on external display as well as one on primary.
TEST_F(WmShelfObserverIconTest, AddRemoveWithMultipleDisplays) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
UpdateDisplay("400x400,400x400");
WmWindow* second_root = WmShell::Get()->GetAllRootWindows()[1];
WmShelf* second_shelf = second_root->GetRootWindowController()->GetShelf();
@@ -1623,6 +1627,10 @@ TEST_F(ShelfViewTest, OverflowBubbleSize) {
// Check the drag insertion bounds of scrolled overflow bubble.
TEST_F(ShelfViewTest, CheckDragInsertBoundsOfScrolledOverflowBubble) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
UpdateDisplay("400x300");
EXPECT_EQ(2, model_->item_count());
@@ -1803,6 +1811,10 @@ TEST_F(ShelfViewTest, CheckOverflowStatusPinOpenedAppToShelf) {
// item is selected.
TEST_F(ShelfViewTest,
Launcher_ButtonPressedUserActionsRecordedWhenItemSelected) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
base::UserActionTester user_action_tester;
ShelfID browser_shelf_id = model_->items()[browser_index_].id;
@@ -1818,6 +1830,10 @@ TEST_F(ShelfViewTest,
// Verifies that Launcher_*Task UMA user actions are recorded when an item is
// selected.
TEST_F(ShelfViewTest, Launcher_TaskUserActionsRecordedWhenItemSelected) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
base::UserActionTester user_action_tester;
ShelfID browser_shelf_id = model_->items()[browser_index_].id;
@@ -2040,6 +2056,10 @@ class ShelfViewInkDropTest : public ShelfViewTest {
// Tests that changing visibility of the app list transitions app list button's
// ink drop states correctly.
TEST_F(ShelfViewInkDropTest, AppListButtonWhenVisibilityChanges) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
InitAppListButtonInkDrop();
ShowAppList();
@@ -2093,6 +2113,10 @@ TEST_F(ShelfViewInkDropTest, AppListButtonMouseEventsWhenHidden) {
// which dismisses the app list, transitions ink drop states correctly. Also,
// tests that mouse drag and mouse release does not affect the ink drop state.
TEST_F(ShelfViewInkDropTest, AppListButtonMouseEventsWhenVisible) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
InitAppListButtonInkDrop();
ShowAppList();
@@ -2156,6 +2180,10 @@ TEST_F(ShelfViewInkDropTest, AppListButtonGestureTapWhenHidden) {
// Tests that when the app list is visible, tapping on the app list button
// transitions ink drop states correctly.
TEST_F(ShelfViewInkDropTest, AppListButtonGestureTapWhenVisible) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
InitAppListButtonInkDrop();
ShowAppList();
@@ -2222,6 +2250,10 @@ TEST_F(ShelfViewInkDropTest, AppListButtonGestureTapDragWhenHidden) {
// Tests that when the app list is visible, tapping down on the app list button
// and dragging the touch point transitions ink drop states correctly.
TEST_F(ShelfViewInkDropTest, AppListButtonGestureTapDragWhenVisible) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
InitAppListButtonInkDrop();
ShowAppList();

Powered by Google App Engine
This is Rietveld 408576698