Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2718763002: [Mac] Reverse order of browser actions in RTL (Closed)

Created:
3 years, 10 months ago by lgrey
Modified:
3 years, 9 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, mac-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Reverse order of browser actions in RTL Dragging works correctly as well BUG=648563 Review-Url: https://codereview.chromium.org/2718763002 Cr-Commit-Position: refs/heads/master@{#453222} Committed: https://chromium.googlesource.com/chromium/src/+/9f898b1b6c9fe4df63bed3150005f83c7b22601c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
lgrey
PTAL :)
3 years, 10 months ago (2017-02-24 20:26:29 UTC) #3
Elly Fong-Jones
lgtm
3 years, 9 months ago (2017-02-27 14:50:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718763002/1
3 years, 9 months ago (2017-02-27 15:17:56 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 15:52:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9f898b1b6c9fe4df63bed3150005...

Powered by Google App Engine
This is Rietveld 408576698