Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2718683002: Let modal view controllers become first responder when presented. (Closed)

Created:
3 years, 10 months ago by lpromero
Modified:
3 years, 10 months ago
Reviewers:
gambard
CC:
chromium-reviews, tfarina, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let modal view controllers become first responder when presented. By becoming first responder, they become the recipient of key presses and prevent the system to automatically focus the omnibox by calling -[UIKeyboardImpl handleTabWithShift:beforePublicKeyCommands:] when the tab key is pressed. BUG=676993 R=gambard@chromium.org Review-Url: https://codereview.chromium.org/2718683002 Cr-Commit-Position: refs/heads/master@{#452835} Committed: https://chromium.googlesource.com/chromium/src/+/a4a59720181d50024b86da5937cc7ae459f725a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M ios/chrome/browser/ui/bookmarks/bookmark_navigation_controller.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/history/history_panel_view_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_navigation_controller.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
lpromero
3 years, 10 months ago (2017-02-24 15:32:46 UTC) #1
gambard
lgtm
3 years, 10 months ago (2017-02-24 15:34:47 UTC) #4
lpromero
https://codereview.chromium.org/2714933002/ will bring tests when EarlGrey support key presses (https://github.com/google/EarlGrey/issues/439).
3 years, 10 months ago (2017-02-24 15:37:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718683002/1
3 years, 10 months ago (2017-02-24 15:45:36 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 15:49:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4a59720181d50024b86da5937cc...

Powered by Google App Engine
This is Rietveld 408576698