Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp

Issue 2718643002: Worker: Pass ParentFrameTaskRunners via WorkerThread::start() instead of the ctor (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp b/third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp
index 6e857bb275866df2bf2cb322267701988f7ea6ce..a02ac4463b85893ecf27d532bfae89a7d9449489 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp
@@ -63,7 +63,6 @@ class AudioWorkletThreadTest : public ::testing::Test {
public:
void SetUp() override {
AudioWorkletThread::createSharedBackingThreadForTest();
- m_parentFrameTaskRunners = ParentFrameTaskRunners::create(nullptr);
m_reportingProxy = TestAudioWorkletReportingProxy::create();
m_securityOrigin =
SecurityOrigin::create(KURL(ParsedURLString, "http://fake.url/"));
@@ -72,13 +71,15 @@ class AudioWorkletThreadTest : public ::testing::Test {
void TearDown() override { AudioWorkletThread::clearSharedBackingThread(); }
std::unique_ptr<AudioWorkletThread> createAudioWorkletThread() {
- std::unique_ptr<AudioWorkletThread> thread = AudioWorkletThread::create(
- nullptr, *m_reportingProxy, m_parentFrameTaskRunners.get());
- thread->start(WorkerThreadStartupData::create(
- KURL(ParsedURLString, "http://fake.url/"), "fake user agent", "",
- nullptr, DontPauseWorkerGlobalScopeOnStart, nullptr, "",
- m_securityOrigin.get(), nullptr, WebAddressSpaceLocal, nullptr, nullptr,
- WorkerV8Settings::Default()));
+ std::unique_ptr<AudioWorkletThread> thread =
+ AudioWorkletThread::create(nullptr, *m_reportingProxy);
+ thread->start(
+ WorkerThreadStartupData::create(
+ KURL(ParsedURLString, "http://fake.url/"), "fake user agent", "",
+ nullptr, DontPauseWorkerGlobalScopeOnStart, nullptr, "",
+ m_securityOrigin.get(), nullptr, WebAddressSpaceLocal, nullptr,
+ nullptr, WorkerV8Settings::Default()),
+ ParentFrameTaskRunners::create(nullptr));
return thread;
}
@@ -104,7 +105,6 @@ class AudioWorkletThreadTest : public ::testing::Test {
RefPtr<SecurityOrigin> m_securityOrigin;
std::unique_ptr<WorkerReportingProxy> m_reportingProxy;
- Persistent<ParentFrameTaskRunners> m_parentFrameTaskRunners;
};
TEST_F(AudioWorkletThreadTest, Basic) {

Powered by Google App Engine
This is Rietveld 408576698