Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 271863005: Revert 268939 "Pass RenderFrameHost to WebContentObservers' mess..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
===================================================================
--- trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (revision 269074)
+++ trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (working copy)
@@ -609,8 +609,7 @@
};
mNativeContentViewCore = nativeInit(
- nativeWebContents, viewAndroidNativePointer, windowNativePointer,
- mRetainedJavaScriptObjects);
+ nativeWebContents, viewAndroidNativePointer, windowNativePointer);
mWebContents = nativeGetWebContentsAndroid(mNativeContentViewCore);
mContentSettings = new ContentSettings(this, mNativeContentViewCore);
initializeContainerView(internalDispatcher);
@@ -2703,7 +2702,8 @@
Class<? extends Annotation> requiredAnnotation) {
if (mNativeContentViewCore != 0 && object != null) {
mJavaScriptInterfaces.put(name, object);
- nativeAddJavascriptInterface(mNativeContentViewCore, object, name, requiredAnnotation);
+ nativeAddJavascriptInterface(mNativeContentViewCore, object, name, requiredAnnotation,
+ mRetainedJavaScriptObjects);
}
}
@@ -3082,7 +3082,7 @@
}
private native long nativeInit(long webContentsPtr,
- long viewAndroidPtr, long windowAndroidPtr, HashSet<Object> retainedObjectSet);
+ long viewAndroidPtr, long windowAndroidPtr);
@CalledByNative
private ContentVideoViewClient getContentVideoViewClient() {
@@ -3236,7 +3236,7 @@
long nativeContentViewCoreImpl, boolean allow);
private native void nativeAddJavascriptInterface(long nativeContentViewCoreImpl, Object object,
- String name, Class requiredAnnotation);
+ String name, Class requiredAnnotation, HashSet<Object> retainedObjectSet);
private native void nativeRemoveJavascriptInterface(long nativeContentViewCoreImpl,
String name);
« no previous file with comments | « trunk/src/content/browser/web_contents/web_contents_impl.cc ('k') | trunk/src/content/public/browser/web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698