Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: net/tools/quic/quic_spdy_client_stream_test.cc

Issue 2718603002: Enable bidi streaming in QUIC by default. Protected by FLAGS_quic_reloadable_flag_quic_always_enabl… (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_simple_server_stream_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_spdy_client_stream_test.cc
diff --git a/net/tools/quic/quic_spdy_client_stream_test.cc b/net/tools/quic/quic_spdy_client_stream_test.cc
index c714086032dfae1c6243cfe7d277f3139c6d693e..915d53913a8b08b27a7a3db0d93fb196d5e7e54c 100644
--- a/net/tools/quic/quic_spdy_client_stream_test.cc
+++ b/net/tools/quic/quic_spdy_client_stream_test.cc
@@ -168,6 +168,9 @@ TEST_F(QuicSpdyClientStreamTest, DISABLED_TestFramingExtraData) {
}
TEST_F(QuicSpdyClientStreamTest, TestNoBidirectionalStreaming) {
+ if (FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
+ return;
+ }
QuicStreamFrame frame(kClientDataStreamId1, false, 3, StringPiece("asd"));
EXPECT_FALSE(stream_->write_side_closed());
@@ -196,9 +199,14 @@ TEST_F(QuicSpdyClientStreamTest, ReceivingTrailers) {
// Now send the body, which should close the stream as the FIN has been
// received, as well as all data.
- EXPECT_CALL(session_, CloseStream(stream_->id()));
+ if (!FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
+ EXPECT_CALL(session_, CloseStream(stream_->id()));
+ }
stream_->OnStreamFrame(
QuicStreamFrame(stream_->id(), /*fin=*/false, /*offset=*/0, body_));
+ if (FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
+ EXPECT_TRUE(stream_->reading_stopped());
+ }
}
} // namespace
« no previous file with comments | « net/tools/quic/quic_simple_server_stream_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698