Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: net/tools/quic/quic_simple_server_stream_test.cc

Issue 2718603002: Enable bidi streaming in QUIC by default. Protected by FLAGS_quic_reloadable_flag_quic_always_enabl… (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | net/tools/quic/quic_spdy_client_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_simple_server_stream_test.cc
diff --git a/net/tools/quic/quic_simple_server_stream_test.cc b/net/tools/quic/quic_simple_server_stream_test.cc
index 3e083ffdd40f1cb15f7c2dec44fffbfa45ab8748..4a444e3c916c177102dc825c69c98c9e138205a1 100644
--- a/net/tools/quic/quic_simple_server_stream_test.cc
+++ b/net/tools/quic/quic_simple_server_stream_test.cc
@@ -326,7 +326,9 @@ TEST_P(QuicSimpleServerStreamTest, SendResponseWithIllegalResponseStatus) {
QuicSimpleServerStreamPeer::SendResponse(stream_);
EXPECT_FALSE(QuicStreamPeer::read_side_closed(stream_));
- EXPECT_TRUE(stream_->reading_stopped());
+ if (!FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
+ EXPECT_TRUE(stream_->reading_stopped());
+ }
EXPECT_TRUE(stream_->write_side_closed());
}
@@ -357,7 +359,9 @@ TEST_P(QuicSimpleServerStreamTest, SendResponseWithIllegalResponseStatus2) {
QuicSimpleServerStreamPeer::SendResponse(stream_);
EXPECT_FALSE(QuicStreamPeer::read_side_closed(stream_));
- EXPECT_TRUE(stream_->reading_stopped());
+ if (!FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
+ EXPECT_TRUE(stream_->reading_stopped());
+ }
EXPECT_TRUE(stream_->write_side_closed());
}
@@ -413,7 +417,9 @@ TEST_P(QuicSimpleServerStreamTest, SendResponseWithValidHeaders) {
QuicSimpleServerStreamPeer::SendResponse(stream_);
EXPECT_FALSE(QuicStreamPeer::read_side_closed(stream_));
- EXPECT_TRUE(stream_->reading_stopped());
+ if (!FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
+ EXPECT_TRUE(stream_->reading_stopped());
+ }
EXPECT_TRUE(stream_->write_side_closed());
}
@@ -517,7 +523,9 @@ TEST_P(QuicSimpleServerStreamTest, TestSendErrorResponse) {
QuicSimpleServerStreamPeer::SendErrorResponse(stream_);
EXPECT_FALSE(QuicStreamPeer::read_side_closed(stream_));
- EXPECT_TRUE(stream_->reading_stopped());
+ if (!FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
+ EXPECT_TRUE(stream_->reading_stopped());
+ }
EXPECT_TRUE(stream_->write_side_closed());
}
@@ -577,6 +585,9 @@ TEST_P(QuicSimpleServerStreamTest, ValidMultipleContentLength) {
}
TEST_P(QuicSimpleServerStreamTest, SendQuicRstStreamNoErrorWithEarlyResponse) {
+ if (FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
+ return;
+ }
InSequence s;
EXPECT_CALL(session_, WriteHeadersMock(stream_->id(), _, false, _, _));
EXPECT_CALL(session_, WritevData(_, _, _, _, _, _))
« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | net/tools/quic/quic_spdy_client_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698