FrameGenerator: Don't issue BeginFrames if we have nothing to draw

FrameGenerator: Don't issue BeginFrames if we have nothing to draw

Updating the device scale factor before the window manager's CompositorFrame
is ready caused a premature BeginFrame in FrameGenerator. This would cause
an invalid CompositorFrame to be generated.

BUG=683732
Review-Url: https://codereview.chromium.org/2718523002
Cr-Commit-Position: refs/heads/master@{#452623}
Committed: https://chromium.googlesource.com/chromium/src/+/9edf32fa33654215032bae96032066bf7e662a9f

[Fady Samuel, 2017-02-23 18:16:33]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2017-02-23 18:16:39]

fsamuel@chromium.org changed reviewers:
+ penghuang@chromium.org

[commit-bot: I haz the power, 2017-02-23 18:17:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peng, 2017-02-23 18:33:59]

On 2017/02/23 18:16:40, Fady Samuel wrote:

lgtm

[commit-bot: I haz the power, 2017-02-23 20:09:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 20:09:30]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-02-23 20:28:20]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-02-23 20:28:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 20:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 20:37:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2017-02-23 20:47:55]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[Fady Samuel, 2017-02-23 20:47:55]

+sky@ for OWNER. This fixes on device black screen.

[sky, 2017-02-23 20:49:34]

LGTM - I encourage you to add test coverage.

[Fady Samuel, 2017-02-23 20:51:30]

On 2017/02/23 20:49:34, sky wrote:
> LGTM - I encourage you to add test coverage.

[Fady Samuel, 2017-02-23 20:52:22]

On 2017/02/23 20:51:30, Fady Samuel wrote:
> On 2017/02/23 20:49:34, sky wrote:
> > LGTM - I encourage you to add test coverage.

I will write a unit test separately. I don't want to keep device builds broken
for much longer.

[Fady Samuel, 2017-02-23 20:52:36]

Description was changed from

==========
FrameGenerator: Don't issue BeginFrames if we have nothing to draw

Updating the device scale factor before the winodw manager's CompositorFrame
is ready caused a premature BeginFrame in FrameGenerator. This would cause
an invalid CompositorFrame to be generated.

BUG=683732
==========

to

==========
FrameGenerator: Don't issue BeginFrames if we have nothing to draw

Updating the device scale factor before the window manager's CompositorFrame
is ready caused a premature BeginFrame in FrameGenerator. This would cause
an invalid CompositorFrame to be generated.

BUG=683732
==========

[Fady Samuel, 2017-02-23 20:52:44]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-02-23 20:53:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 20:58:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487883164930110, "parent_rev":
"f747b99b3a9c6ddac3470d61d3f292a019e1c1c2", "commit_rev":
"9edf32fa33654215032bae96032066bf7e662a9f"}

[commit-bot: I haz the power, 2017-02-23 20:59:16]

Description was changed from

==========
FrameGenerator: Don't issue BeginFrames if we have nothing to draw

Updating the device scale factor before the window manager's CompositorFrame
is ready caused a premature BeginFrame in FrameGenerator. This would cause
an invalid CompositorFrame to be generated.

BUG=683732
==========

to

==========
FrameGenerator: Don't issue BeginFrames if we have nothing to draw

Updating the device scale factor before the window manager's CompositorFrame
is ready caused a premature BeginFrame in FrameGenerator. This would cause
an invalid CompositorFrame to be generated.

BUG=683732

Review-Url: https://codereview.chromium.org/2718523002
Cr-Commit-Position: refs/heads/master@{#452623}
Committed:
https://chromium.googlesource.com/chromium/src/+/9edf32fa33654215032bae960320...
==========

[commit-bot: I haz the power, 2017-02-23 20:59:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9edf32fa33654215032bae960320...