Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: tests/language/void_check_test.dart

Issue 2718513002: Void is not required to be `null` anymore. (Closed)
Patch Set: Fix more places in the VM. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/void_check_test.dart
diff --git a/tests/language/void_check_test.dart b/tests/language/void_check_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..e0cf47b63865b44a8806200cb2c329352ea5350c
--- /dev/null
+++ b/tests/language/void_check_test.dart
@@ -0,0 +1,36 @@
+// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Tests that `void` accepts any value and won't throw on non-`null` values.
+// The test is set up in a way that `--trust-type-annotations` and type
+// propagation must not assume that `void` is `null` either.
+
+import 'package:expect/expect.dart';
+
+class A {
+ void foo() {
+ return bar();
Lasse Reichstein Nielsen 2017/03/02 07:21:49 indentation is off.
regis 2017/03/22 16:29:32 This line hurts my eyes, and it is not because of
regis 2017/03/22 16:33:48 Ignore this comment. It was saved as a draft and p
+ }
+ void bar() {}
+}
+
+class B extends A {
+ int bar() => 42;
+}
+
+// Makes the typing cleaner: the return type here is `dynamic` and we are
+// guaranteed that there won't be any warnings.
+// Dart2js can still infer the type by itself.
+@NoInline()
+callFoo(A a) => a.foo();
+
+main() {
+ var a = new A();
+ var b = new B();
+ // The following line is not throwing, even though `a.foo()` (inside
+ // `callFoo`) is supposedly `void`.
+ callFoo(b).abs();
+ Expect.isNull(callFoo(a));
+ Expect.equals(42, callFoo(b));
+}

Powered by Google App Engine
This is Rietveld 408576698