Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/object.cc

Issue 2718513002: Void is not required to be `null` anymore. (Closed)
Patch Set: Fix more places in the VM. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | sdk/lib/_internal/js_runtime/lib/js_helper.dart » ('j') | tests/language/void_check_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index b78cc697313a673a13185cc41ad7b0381ee57931..8383e54f92a1398af4eb24beebd1092d41c7e49f 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -15642,7 +15642,7 @@ bool Instance::IsInstanceOf(const AbstractType& other,
ASSERT(!other.IsMalformed());
ASSERT(!other.IsMalbounded());
if (other.IsVoidType()) {
- return false;
+ return true;
}
Zone* zone = Thread::Current()->zone();
const Class& cls = Class::Handle(zone, clazz());
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | sdk/lib/_internal/js_runtime/lib/js_helper.dart » ('j') | tests/language/void_check_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698