Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/js_runtime/lib/js_helper.dart

Issue 2718513002: Void is not required to be `null` anymore. (Closed)
Patch Set: Fix more places in the VM. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/object.cc ('K') | « runtime/vm/object.cc ('k') | tests/language/return_type_test.dart » ('j') | tests/language/void_check_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/js_runtime/lib/js_helper.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/js_helper.dart b/sdk/lib/_internal/js_runtime/lib/js_helper.dart
index 6e1548d396a3bb7cc40f13fa0de52e07bad54cc7..99fdcc8719a20f2d351bcf5e1bff8d8cb54a3b04 100644
--- a/sdk/lib/_internal/js_runtime/lib/js_helper.dart
+++ b/sdk/lib/_internal/js_runtime/lib/js_helper.dart
@@ -3356,11 +3356,6 @@ listSuperNativeTypeCast(value, property) {
propertyTypeCastError(value, property);
}
-voidTypeCheck(value) {
- if (value == null) return value;
- throw new TypeErrorImplementation(value, 'void');
-}
-
extractFunctionTypeObjectFrom(o) {
var interceptor = getInterceptor(o);
var signatureName = JS_GET_NAME(JsGetName.SIGNATURE_NAME);
« runtime/vm/object.cc ('K') | « runtime/vm/object.cc ('k') | tests/language/return_type_test.dart » ('j') | tests/language/void_check_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698