runtime/vm/flow_graph_builder.cc - Issue 2718513002: Void is not required to be `null` anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 2718513002: Void is not required to be `null` anymore. (Closed)

Patch Set: Fix more places in the VM. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index bb52f8fa7cc0cf857c081b7598267eb3ddd4131a..5077e7d12dfcd051f4653a2a989c4fd7355febb2 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -1245,8 +1245,9 @@ bool EffectGraphVisitor::CanSkipTypeCheck(TokenPosition token_pos,

return false;

}

- // Any type is more specific than the dynamic type and than the Object type.

- if (dst_type.IsDynamicType() || dst_type.IsObjectType()) {

+ // Any type is more specific than the dynamic type, the Object type, or void.

+ if (dst_type.IsDynamicType() || dst_type.IsObjectType() ||

+ dst_type.IsVoidType()) {

return true;

}