Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2718503002: [Mac] Reverse tab alert buttons (i.e. audio) in RTL (Closed)

Created:
3 years, 10 months ago by lgrey
Modified:
3 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Reverse tab alert buttons (i.e. audio) in RTL BUG=693774 Review-Url: https://codereview.chromium.org/2718503002 Cr-Commit-Position: refs/heads/master@{#452581} Committed: https://chromium.googlesource.com/chromium/src/+/8a316f5df03d63bf8b588cf8741063133572bea3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm View 2 chunks +9 lines, -3 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
lgrey
PTAL :)
3 years, 10 months ago (2017-02-23 17:34:02 UTC) #2
Avi (use Gerrit)
lgtm https://codereview.chromium.org/2718503002/diff/1/chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm File chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm (right): https://codereview.chromium.org/2718503002/diff/1/chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm#newcode94 chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm:94: affordanceImage = cocoa_l10n_util::FlippedImage(affordanceImage); Both at once! 👍
3 years, 10 months ago (2017-02-23 18:55:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718503002/1
3 years, 10 months ago (2017-02-23 18:57:23 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 19:23:52 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a316f5df03d63bf8b588cf87410...

Powered by Google App Engine
This is Rietveld 408576698