Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2718493003: Delete battor.power_cases and the power_cases page set (Closed)

Created:
3 years, 10 months ago by charliea (OOO until 10-5)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete battor.power_cases and the power_cases page set battor.power_cases was originally written as a simple benchmark to get up on the FYI waterfall to make sure that BattOr benchmarks could run. Fast forward to now, where it has three stories (about:blank, YouTube, and poster circle), two of which are covered by the system_health.common benchmark we have in place and the third (poster circle) that's already been named as an unrealistic story. BUG=695543 Review-Url: https://codereview.chromium.org/2718493003 Cr-Commit-Position: refs/heads/master@{#453961} Committed: https://chromium.googlesource.com/chromium/src/+/798a5b1d03f4760f0c5df2404c3af3c666259b69

Patch Set 1 #

Patch Set 2 : Deleted the WPR info and updated the JSON #

Patch Set 3 : Synced to head, where Ned is in the OWNERS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1590 lines, -2739 lines) Patch
M testing/buildbot/chromium.perf.json View 1 1304 chunks +1288 lines, -2200 lines 0 comments Download
M testing/buildbot/chromium.perf.fyi.json View 1 305 chunks +302 lines, -473 lines 0 comments Download
M tools/perf/benchmarks/battor.py View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
D tools/perf/page_sets/data/power_cases.json View 1 1 chunk +0 lines, -15 lines 0 comments Download
D tools/perf/page_sets/data/power_cases_000.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/power_cases_001.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/power_cases_002.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/power_cases.py View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
charliea (OOO until 10-5)
3 years, 10 months ago (2017-02-23 18:43:06 UTC) #2
rnephew (Reviews Here)
On 2017/02/23 18:43:06, charliea wrote: We should also delete the data in tools/perf/page_sets/data
3 years, 10 months ago (2017-02-23 19:08:09 UTC) #3
charliea (OOO until 10-5)
Good call. Did that and updated the perf JSON. (I do learn! Sometimes.) PTAL
3 years, 9 months ago (2017-02-27 15:21:07 UTC) #4
nednguyen
lgtm
3 years, 9 months ago (2017-02-28 19:57:16 UTC) #5
rnephew (Reviews Here)
On 2017/02/28 19:57:16, nednguyen wrote: > lgtm lgtm
3 years, 9 months ago (2017-02-28 19:58:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718493003/20001
3 years, 9 months ago (2017-02-28 20:00:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/374841)
3 years, 9 months ago (2017-02-28 20:11:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718493003/40001
3 years, 9 months ago (2017-03-01 16:08:37 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 17:39:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/798a5b1d03f4760f0c5df2404c3a...

Powered by Google App Engine
This is Rietveld 408576698