Add apk-patch-size-estimator to //third_party.

Add apk-patch-size-estimator to //third_party.

apk-patch-size-estimator is a tool for estimating the Google Play patch
size given two APKs. Chrome on Android will use this to help identify
CLs that cause large patch size changes.

BUG=695188
Review-Url: https://codereview.chromium.org/2718423002
Cr-Commit-Position: refs/heads/master@{#455588}
Committed: https://chromium.googlesource.com/chromium/src/+/7e75c4ffb31e9e3514425bf08d5009aa10de9ffa

[estevenson, 2017-02-28 21:27:51]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2017-02-28 21:27:52]

ptal Andrew!

The script tries to find a bsdiff binary by running "which bsdiff" (similarly
for gzip, head, tail, gunzip2, java - but these should be installed on all
machines).

So we'll need to point the script at a bsdiff binary. I can see two versions in
chromium:
https://cs.chromium.org/chromium/src/chrome/installer/mac/third_party/bsdiff/
(minor modifications) and
https://cs.chromium.org/chromium/src/courgette/third_party/bsdiff/?q=bsdiff
(major modifications, not usable).

Seems like we'll need to check in another one from here:
http://www.daemonology.net/bsdiff/? Should I create another //third_party dir
for it or just plop it in here?

[estevenson, 2017-02-28 22:14:18]

On 2017/02/28 21:27:52, estevenson wrote:
> ptal Andrew!
> 
> The script tries to find a bsdiff binary by running "which bsdiff" (similarly
> for gzip, head, tail, gunzip2, java - but these should be installed on all
> machines).
> 
> So we'll need to point the script at a bsdiff binary. I can see two versions
in
> chromium:
> https://cs.chromium.org/chromium/src/chrome/installer/mac/third_party/bsdiff/
> (minor modifications) and
> https://cs.chromium.org/chromium/src/courgette/third_party/bsdiff/?q=bsdiff
> (major modifications, not usable).
> 
> Seems like we'll need to check in another one from here:
> http://www.daemonology.net/bsdiff/ Should I create another //third_party dir
> for it or just plop it in here?

Discussed offline, we will install bsdiff on bots as needed. Regardless, this CL
doesn't required bsdiff to be installed.

[agrieve, 2017-03-01 01:42:19]

On 2017/02/28 22:14:18, estevenson wrote:
> On 2017/02/28 21:27:52, estevenson wrote:
> > ptal Andrew!
> > 
> > The script tries to find a bsdiff binary by running "which bsdiff"
(similarly
> > for gzip, head, tail, gunzip2, java - but these should be installed on all
> > machines).
> > 
> > So we'll need to point the script at a bsdiff binary. I can see two versions
> in
> > chromium:
> >
https://cs.chromium.org/chromium/src/chrome/installer/mac/third_party/bsdiff/
> > (minor modifications) and
> > https://cs.chromium.org/chromium/src/courgette/third_party/bsdiff/?q=bsdiff
> > (major modifications, not usable).
> > 
> > Seems like we'll need to check in another one from here:
> > http://www.daemonology.net/bsdiff/ Should I create another //third_party dir
> > for it or just plop it in here?
> 
> Discussed offline, we will install bsdiff on bots as needed. Regardless, this
CL
> doesn't required bsdiff to be installed.

lgtm

[palmer, 2017-03-02 19:38:07]

palmer@chromium.org changed reviewers:
+ palmer@chromium.org

[palmer, 2017-03-02 19:38:07]

lgtm

[xam, 2017-03-02 20:19:13]

On 2017/03/02 19:38:07, palmer wrote:
> lgtm

LGTM from OSTPR

[brettw, 2017-03-08 19:09:12]

brettw@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2017-03-08 19:09:12]

lgtm

[estevenson, 2017-03-08 21:33:36]

The CQ bit was checked by estevenson@chromium.org

[commit-bot: I haz the power, 2017-03-08 21:34:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 23:20:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489008816243210, "parent_rev":
"b198ea3c95980c9a6566f3a6b8f999aeb9459737", "commit_rev":
"7e75c4ffb31e9e3514425bf08d5009aa10de9ffa"}

[commit-bot: I haz the power, 2017-03-08 23:20:51]

Description was changed from

==========
Add apk-patch-size-estimator to //third_party.

apk-patch-size-estimator is a tool for estimating the Google Play patch
size given two APKs. Chrome on Android will use this to help identify
CLs that cause large patch size changes.

BUG=695188
==========

to

==========
Add apk-patch-size-estimator to //third_party.

apk-patch-size-estimator is a tool for estimating the Google Play patch
size given two APKs. Chrome on Android will use this to help identify
CLs that cause large patch size changes.

BUG=695188

Review-Url: https://codereview.chromium.org/2718423002
Cr-Commit-Position: refs/heads/master@{#455588}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e75c4ffb31e9e3514425bf08d50...
==========

[commit-bot: I haz the power, 2017-03-08 23:20:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e75c4ffb31e9e3514425bf08d50...