Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2718353002: Revert "Track the 'awaiter return' call stack..." (Closed)

Created:
3 years, 9 months ago by Kevin Millikin (Google)
Modified:
3 years, 9 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Track the 'awaiter return' call stack..." Revert a pair of commits that cause failure of the Kernel continuation transformer: cba7e3e79adf41814060119bb61faff7bb658865 4fe4f177dead7039879441f8c4ba4836727b0317 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/a0965a641f5fc465372225dbd60a7faad44d1766

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -773 lines) Patch
M runtime/lib/async_patch.dart View 4 chunks +3 lines, -37 lines 0 comments Download
D runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D runtime/observatory/tests/service/pause_on_unhandled_async_exceptions_test.dart View 1 chunk +0 lines, -65 lines 0 comments Download
M runtime/vm/ast.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/ast_transformer.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M runtime/vm/code_descriptors.h View 4 chunks +0 lines, -8 lines 0 comments Download
M runtime/vm/code_descriptors.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M runtime/vm/debugger.h View 6 chunks +6 lines, -25 lines 0 comments Download
M runtime/vm/debugger.cc View 9 chunks +34 lines, -358 lines 0 comments Download
M runtime/vm/exceptions.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph.h View 2 chunks +0 lines, -10 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.h View 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 5 chunks +1 line, -13 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +2 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/kernel_to_il.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/object.cc View 7 chunks +4 lines, -23 lines 0 comments Download
M runtime/vm/object_service.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M runtime/vm/parser.cc View 8 chunks +6 lines, -63 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/scopes.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M runtime/vm/symbols.h View 4 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
3 years, 9 months ago (2017-02-28 11:28:03 UTC) #2
kustermann
LGTM
3 years, 9 months ago (2017-02-28 11:28:27 UTC) #3
Kevin Millikin (Google)
3 years, 9 months ago (2017-02-28 11:46:40 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a0965a641f5fc465372225dbd60a7faad44d1766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698