Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: runtime/vm/scopes.cc

Issue 2718353002: Revert "Track the 'awaiter return' call stack..." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/scopes.h" 5 #include "vm/scopes.h"
6 6
7 #include "vm/object.h" 7 #include "vm/object.h"
8 #include "vm/stack_frame.h" 8 #include "vm/stack_frame.h"
9 #include "vm/symbols.h" 9 #include "vm/symbols.h"
10 10
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 } 257 }
258 258
259 259
260 // The parser creates internal variables that start with ":" 260 // The parser creates internal variables that start with ":"
261 static bool IsFilteredIdentifier(const String& str) { 261 static bool IsFilteredIdentifier(const String& str) {
262 ASSERT(str.Length() > 0); 262 ASSERT(str.Length() > 0);
263 if (str.raw() == Symbols::AsyncOperation().raw()) { 263 if (str.raw() == Symbols::AsyncOperation().raw()) {
264 // Keep :async_op for asynchronous debugging. 264 // Keep :async_op for asynchronous debugging.
265 return false; 265 return false;
266 } 266 }
267 if (str.raw() == Symbols::AsyncCompleter().raw()) {
268 // Keep :async_completer for asynchronous debugging.
269 return false;
270 }
271 if (str.raw() == Symbols::ControllerStream().raw()) {
272 // Keep :controller_stream for asynchronous debugging.
273 return false;
274 }
275 if (str.raw() == Symbols::AwaitJumpVar().raw()) {
276 // Keep :await_jump_var for asynchronous debugging.
277 return false;
278 }
279 return str.CharAt(0) == ':'; 267 return str.CharAt(0) == ':';
280 } 268 }
281 269
282 270
283 RawLocalVarDescriptors* LocalScope::GetVarDescriptors(const Function& func) { 271 RawLocalVarDescriptors* LocalScope::GetVarDescriptors(const Function& func) {
284 GrowableArray<VarDesc> vars(8); 272 GrowableArray<VarDesc> vars(8);
285 // First enter all variables from scopes of outer functions. 273 // First enter all variables from scopes of outer functions.
286 const ContextScope& context_scope = 274 const ContextScope& context_scope =
287 ContextScope::Handle(func.context_scope()); 275 ContextScope::Handle(func.context_scope());
288 if (!context_scope.IsNull()) { 276 if (!context_scope.IsNull()) {
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 return fixed_parameter_count - (index() - kParamEndSlotFromFp); 686 return fixed_parameter_count - (index() - kParamEndSlotFromFp);
699 } else { 687 } else {
700 // Shift negative indexes so that the lowest one is 0 (they are still 688 // Shift negative indexes so that the lowest one is 0 (they are still
701 // non-positive). 689 // non-positive).
702 return fixed_parameter_count - (index() - kFirstLocalSlotFromFp); 690 return fixed_parameter_count - (index() - kFirstLocalSlotFromFp);
703 } 691 }
704 } 692 }
705 693
706 694
707 } // namespace dart 695 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698